[chore][receiver/sqlserver] update error handling and time unit and refactory #39042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/sqlserver
Run Windows
XSAM
reviewed
Mar 29, 2025
XSAM
reviewed
Mar 29, 2025
XSAM
reviewed
Mar 30, 2025
…tor-contrib into update-unit-and-refactory
|
updated @XSAM |
XSAM
approved these changes
Mar 30, 2025
crobert-1
approved these changes
Mar 31, 2025
|
…tor-contrib into update-unit-and-refactory
|
a change log was added |
crobert-1
reviewed
Apr 1, 2025
…tor-contrib into update-unit-and-refactory
crobert-1
approved these changes
Apr 1, 2025
crobert-1
added
the
ready to merge
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
…efactory (open-telemetry#39042) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description - update time unit of `lock_timeout`, this one was not updated in the previous pr - update error handling in sample query, the previous version ignored all the errors - update top query logic on put attributes to similar to sample query <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…efactory (open-telemetry#39042) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description - update time unit of `lock_timeout`, this one was not updated in the previous pr - update error handling in sample query, the previous version ignored all the errors - update top query logic on put attributes to similar to sample query <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lock_timeout, this one was not updated in the previous prLink to tracking issue
Fixes
Testing
Documentation