[receiver/sqlserver] Ensure all enabled metrics are emitted #38839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Mar 20, 2025
dehaansa
approved these changes
Mar 20, 2025
- Return result of ||, rather than include if
atoulme
approved these changes
Mar 20, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…emetry#38839) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description When directly connecting to SQL Server, this receiver runs multiple queries to get enabled metrics. Each query is only run if one or more metric is enabled for that particular query. The bug here was that some metrics weren't properly being checked to see if they were enabled. This means that in some cases, if a subset of metrics were enabled, the query wouldn't be run, and the metrics wouldn't be recorded or emitted. <!--Describe what testing was performed and which tests were added.--> #### Testing Added a test to ensure whenever new metrics are added, the `setupQueries` method gets changed as well. If we continue to hit more bugs with this we may want to just always run the queries, even if there's a slight performance hit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When directly connecting to SQL Server, this receiver runs multiple queries to get enabled metrics. Each query is only run if one or more metric is enabled for that particular query. The bug here was that some metrics weren't properly being checked to see if they were enabled. This means that in some cases, if a subset of metrics were enabled, the query wouldn't be run, and the metrics wouldn't be recorded or emitted.
Testing
Added a test to ensure whenever new metrics are added, the
setupQueriesmethod gets changed as well. If we continue to hit more bugs with this we may want to just always run the queries, even if there's a slight performance hit.