-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Support bearerauthtoken header customization #38793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bearerauthtoken header customization #38793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking that up @nahguam !
LGTM, but we are missing a changelog. You can create one by running make chlog-new
and modifing the generated file in .chloggen/bearerauth-header.yaml
.
Moving to draft while you add the changelog. Please mark ready for review afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seems appropriate. Need a codeowner review.
f8c7638
into
open-telemetry:main
#### Description Adding a feature - Allow the header name to be customized in the bearerauthtoken extension #### Testing Added tests and ran all tests for the extension. #### Documentation Updated readme for the extension
#### Description Adding a feature - Allow the header name to be customized in the bearerauthtoken extension #### Testing Added tests and ran all tests for the extension. #### Documentation Updated readme for the extension
Description
Adding a feature - Allow the header name to be customized in the bearerauthtoken extension
Testing
Added tests and ran all tests for the extension.
Documentation
Updated readme for the extension