Skip to content

Support bearerauthtoken header customization #38793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

nahguam
Copy link
Contributor

@nahguam nahguam commented Mar 19, 2025

Description

Adding a feature - Allow the header name to be customized in the bearerauthtoken extension

Testing

Added tests and ran all tests for the extension.

Documentation

Updated readme for the extension

@nahguam nahguam requested review from jpkrohling and a team as code owners March 19, 2025 10:04
Copy link

linux-foundation-easycla bot commented Mar 19, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking that up @nahguam !

LGTM, but we are missing a changelog. You can create one by running make chlog-new and modifing the generated file in .chloggen/bearerauth-header.yaml.

@atoulme atoulme marked this pull request as draft March 20, 2025 05:38
@atoulme
Copy link
Contributor

atoulme commented Mar 20, 2025

Moving to draft while you add the changelog. Please mark ready for review afterwards.

@nahguam nahguam marked this pull request as ready for review March 20, 2025 09:49
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seems appropriate. Need a codeowner review.

@andrzej-stencel andrzej-stencel merged commit f8c7638 into open-telemetry:main Mar 28, 2025
182 of 183 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 28, 2025
@nahguam nahguam deleted the bearerauth-header branch April 1, 2025 09:57
dmathieu pushed a commit to dmathieu/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2025
#### Description

Adding a feature - Allow the header name to be customized in the
bearerauthtoken extension

#### Testing

Added tests and ran all tests for the extension.

#### Documentation

Updated readme for the extension
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
#### Description

Adding a feature - Allow the header name to be customized in the
bearerauthtoken extension

#### Testing

Added tests and ran all tests for the extension.

#### Documentation

Updated readme for the extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants