Skip to content

[processor/resourcedetection] Add os.version resource attribute #38087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 20, 2025

Conversation

avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Feb 20, 2025

Description

Adding the os.version resource attribute to system resourcedetection processor

Link to tracking issue

Fixes: #38059

Testing

Updated unit tests.

Documentation

N/A

@avilevy18 avilevy18 marked this pull request as ready for review February 20, 2025 20:13
@avilevy18 avilevy18 requested review from evan-bradley and a team as code owners February 20, 2025 20:13
Copy link
Member

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @avilevy18!

@ridwanmsharif
Copy link
Member

@ridwanmsharif
Copy link
Member

You might need to rebase on main again for the vuln fixes.

@Aneurysm9 do you mind taking a look at this PR when you have a chance?

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my review.

@atoulme atoulme marked this pull request as draft March 17, 2025 23:16
@avilevy18 avilevy18 marked this pull request as ready for review March 19, 2025 19:19
@avilevy18 avilevy18 requested a review from ridwanmsharif March 19, 2025 19:21
@avilevy18 avilevy18 requested a review from atoulme March 19, 2025 19:21
Copy link
Member

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

os.version:
description: The os.version
type: string
enabled: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is confusing for me as to why some of these attributes are enabled by default and why others are not.

I found #21482 which adds some context for atleast host.id which is reasonable.

IMO though, the os.version though reasonably should be enabled here by default but I'm okay with the earlier suggestion of making this enabled by default as a separate change that we mark as breaking in the changelog.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think of this also as a way to test things out for some users before we turn this on by default. This is all the more true for metrics, resource attributes can create time series recreations which can be painful if users are not aware of it.

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Mar 20, 2025
@atoulme atoulme merged commit c49361a into open-telemetry:main Mar 20, 2025
177 of 179 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 20, 2025
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this pull request Apr 24, 2025
…en-telemetry#38087)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adding the `os.version` resource attribute to system `resourcedetection`
processor

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes: open-telemetry#38059

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Updated unit tests.

<!--Describe the documentation added.-->
#### Documentation
N/A

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/metadataproviders processor/resourcedetection Resource detection processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resourcedetection: Add os.version as a resource attribute
7 participants