You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The fix for multi-line logs from a while back prevents deliberately batching multiple events by using a line break. The specific goal I have here is to support Auth0 web hooks and similarly setup, very concise events that wouldn't have multiple lines.
I agree that the present default is better for most webhook situations, however some use fewer webhooks with batches of events in the body. I'd like to add a configuration such as SplitLogsAtNewLine and when set to True, it would use the default bufio reader.
Describe alternatives you've considered
I've looked into the other approaches within the webhook products, array of JSON, and object full of objects. In either case, the unmarshalling process will create more confusion and rigidity.
With the newline break approach, it will allow a transform processor to be used for further parsing/flattening. It also allows a filter processor to sanity test that the body lines are properly formatted. The current approach of putting them all in one body prevents the other transforms from splitting them back out.
Additional context
I'm happy to submit the PR for this.
The text was updated successfully, but these errors were encountered:
Component(s)
receiver/webhookevent
Is your feature request related to a problem? Please describe.
The fix for multi-line logs from a while back prevents deliberately batching multiple events by using a line break. The specific goal I have here is to support Auth0 web hooks and similarly setup, very concise events that wouldn't have multiple lines.
Prior fix: #3502
Describe the solution you'd like
I agree that the present default is better for most webhook situations, however some use fewer webhooks with batches of events in the body. I'd like to add a configuration such as
SplitLogsAtNewLine
and when set to True, it would use the default bufio reader.Describe alternatives you've considered
I've looked into the other approaches within the webhook products, array of JSON, and object full of objects. In either case, the unmarshalling process will create more confusion and rigidity.
With the newline break approach, it will allow a transform processor to be used for further parsing/flattening. It also allows a filter processor to sanity test that the body lines are properly formatted. The current approach of putting them all in one body prevents the other transforms from splitting them back out.
Additional context
I'm happy to submit the PR for this.
The text was updated successfully, but these errors were encountered: