[datadogreceiver] unset/unspecified type results in no processed data

[wiardvanrij]

Component(s)

receiver/datadog

What happened?

Description

It's not required to set type.

However, not setting the type means that data seems to be completely lost. The receiver does say 'OK', as in it received the request, but it doesn't seem to process it futher.

Steps to Reproduce

note of not including the arg type

curl  -X POST -H "Content-type: application/json" \
    -d '{ "series" :
         [{"metric":"some_metric",
          "points":[['${current_time}', '${metric_val}']],
        "tags":["host:'foo'"]}
    ]
    }' \
    'https://your-endpoint/api/v1/series'

Expected Result

OTeL receiver parses this and then I can forward it to any remote metric endpoint

Actual Result

No data gets forwarded

Extra

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/datadogreceiver/internal/translator/series.go#L66

No NumberDataPointSlice gets set in the switch. I find it very hard to parse the logic, but I'm assuming because this 'DPS' doesn't get set, further down the line the data isn't getting used at all: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/datadogreceiver/internal/translator/series.go#L90
Which makes it just a null value.

Also small nit; there are no unit tests for not setting the type.

extra part 2

I do sort of get the point of that in an ideal case.. the type is set. How else can we infer data. Yet, it doesn't seem to be a required thing on DD itself so I would actually prefer if somehow we can (maybe best effort) make something of it?

Collector version

lastest

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• receiver/datadog: @boostchicken @gouthamve @jpkrohling @MovieStoreGuy

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[atoulme]

Please separate your issue into multiple issues as it seems the "Extra" paragraphs report other errors.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/datadog: @boostchicken @gouthamve @MovieStoreGuy

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• receiver/datadogreceiver: @boostchicken @gouthamve @MovieStoreGuy

See Adding Labels via Comments if you do not have permissions to add labels yourself.