[receiver/vcenter] Change Host Perf Metric Reported Datapoints From 5 to 1 #34708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
fix/extra-host-metrics
branch
from
33b68c0 to
0d3aa79
Compare
djaglowski
reviewed
Aug 15, 2024
StefanKurek
force-pushed
the
fix/extra-host-metrics
branch
from
e92eec4 to
cd011b6
Compare
djaglowski
reviewed
Aug 16, 2024
djaglowski
approved these changes
Aug 16, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
… to 1 (open-telemetry#34708) **Description:** <Describe what has changed.> This is something that I thought was a little odd for awhile, but didn't necessarily hurt anything until I ran into issues with the googlecloud exporter. It seems to have issues with the Host performance metrics sending historical data with timestamps 20s apart and reported it as a Duplicate error. This also brings the Host performance metrics in line with what is being done with the VM performance metrics (only sending a single current datapoint vs 5 historical ones). Now we'll also generally avoid situations where timetamps at the tail end of these 5 datapoints would end up being picked up by the following collection as well. **Link to tracking Issue:** NA **Testing:** Unit Tests Ran Integration Tests Ran Tested Against Live Environment **Documentation:** <Describe the documentation added.> None needed --------- Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is something that I thought was a little odd for awhile, but didn't necessarily hurt anything until I ran into issues with the googlecloud exporter. It seems to have issues with the Host performance metrics sending historical data with timestamps 20s apart and reported it as a Duplicate error.
This also brings the Host performance metrics in line with what is being done with the VM performance metrics (only sending a single current datapoint vs 5 historical ones). Now we'll also generally avoid situations where timetamps at the tail end of these 5 datapoints would end up being picked up by the following collection as well.
Link to tracking Issue: NA
Testing:
Unit Tests Ran
Integration Tests Ran
Tested Against Live Environment
Documentation:
None needed