Skip to content

Change the hashing algorithm for probabilistic sampler #16456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpkrohling opened this issue Nov 23, 2022 · 4 comments
Closed

Change the hashing algorithm for probabilistic sampler #16456

jpkrohling opened this issue Nov 23, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers processor/probabilisticsampler Probabilistic Sampler processor

Comments

@jpkrohling
Copy link
Member

In the probabilistic sampler, we seem to use a hashing algorithm of our own, instead of relying on a library to do so, as it's done in other modules. We should try to follow the guideline we have on this:

https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#recommended-libraries--defaults

Originally posted by @MovieStoreGuy in #14920 (comment)

@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers processor/probabilisticsampler Probabilistic Sampler processor labels Nov 23, 2022
@moonbox3
Copy link
Contributor

moonbox3 commented Dec 9, 2022

@jpkrohling I'd like to work on this issue, if possible. I'm new to the project and will spend time time wrapping my head around things. I'll most likely come back with questions.

@fatsheep9146
Copy link
Contributor

@moonbox3 It's yours! Thanks!

@moonbox3
Copy link
Contributor

Created the PR for this here.

@jpkrohling
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers processor/probabilisticsampler Probabilistic Sampler processor
Projects
None yet
Development

No branches or pull requests

3 participants