[receiver/vcenter] Bump receiver.vcenter.emitPerfMetricsWithObjects feature gate (#30616)

Updates #30615

---------

Co-authored-by: Evan Bradley <[email protected]>

Author: djaglowski

.chloggen/bump-vcenter-gate.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: vcenterreceiver
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Bump "receiver.vcenter.emitPerfMetricsWithObjects" feature gate
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [30615]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

receiver/vcenterreceiver/README.md

@@ -78,17 +78,12 @@ These metrics were incorrectly dimensioned previously but the desired fix is a b
 
 These metrics were improperly dimensioned and needed another metric attribute `object` in order to properly dimension the data.
 
-1. v0.84.0, August 2023:
-
-- The version of the receiver will keep default behavior.
-- `receiver.vcenter.emitPerfMetricsWithObjects` is *disabled* by default.
-
-2. v0.86.0, September 2023:
+#### v0.93.0, January 2024
 
 - The receiver will emit the `object` metric attribute by default
 - `receiver.vcenter.emitPerfMetricsWithObjects` is *enabled* by default.
 
-3. v0.88.0, October 2023:
+#### v0.95.0, February 2024
 
 - The feature gates are removed.
 - Performance metrics will always include the `object` metric attribute.

receiver/vcenterreceiver/scraper.go

@@ -27,7 +27,7 @@ const (
 
 var emitPerfMetricsWithObjects = featuregate.GlobalRegistry().MustRegister(
 	emitPerfMetricsWithObjectsFeatureGateID,
-	featuregate.StageAlpha,
+	featuregate.StageBeta,
 	featuregate.WithRegisterDescription("When enabled, the receiver emits vCenter performance metrics with object metric label dimension."),
 )
 

receiver/vcenterreceiver/scraper_test.go

@@ -33,7 +33,7 @@ func TestScrape(t *testing.T) {
 	testScrape(ctx, t, cfg)
 }
 
-func TestScrapeWithPerfObjects(t *testing.T) {
+func TestScrapeWithoutPerfObjects(t *testing.T) {
 	ctx := context.Background()
 	mockServer := mock.MockServer(t, false)
 	defer mockServer.Close()
@@ -46,13 +46,13 @@ func TestScrapeWithPerfObjects(t *testing.T) {
 	}
 
 	scraper := newVmwareVcenterScraper(zap.NewNop(), cfg, receivertest.NewNopCreateSettings())
-	scraper.emitPerfWithObject = true
+	scraper.emitPerfWithObject = false
 
 	metrics, err := scraper.scrape(ctx)
 	require.NoError(t, err)
 	require.NotEqual(t, metrics.MetricCount(), 0)
 
-	goldenPath := filepath.Join("testdata", "metrics", "expected_with_object.yaml")
+	goldenPath := filepath.Join("testdata", "metrics", "expected_without_objects.yaml")
 	expectedMetrics, err := golden.ReadMetrics(goldenPath)
 	require.NoError(t, err)