Skip to content

Commit f33dd45

Browse files
committed
[exporter/signalfx] Log dropped data points with over 36 dimensions at warn log level
1 parent 8c275f4 commit f33dd45

File tree

2 files changed

+31
-1
lines changed

2 files changed

+31
-1
lines changed

.chloggen/warn_on_dropped_dp.yaml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: signalfxexporter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Warn on dropping metric data points when they have more than allowed dimension count
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: []
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext: |
19+
The SignalFx exporter drops metric data points if they have more than 36 dimensions.
20+
Currently, the exporter logs at debug level when this occurs.
21+
With this change, the exporter will log at the warning level.
22+
23+
# If your change doesn't affect end users or the exported elements of any package,
24+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
25+
# Optional: The change log or logs in which this entry should be included.
26+
# e.g. '[user]' or '[user, api]'
27+
# Include 'user' if the change is relevant to end users.
28+
# Include 'api' if there is a change to a library API.
29+
# Default: '[user]'
30+
change_logs: []

exporter/signalfxexporter/internal/translation/converter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ func (dpv *datapointValidator) isValidMetricName(name string) bool {
254254

255255
func (dpv *datapointValidator) isValidNumberOfDimension(dp *sfxpb.DataPoint) bool {
256256
if len(dp.Dimensions) > maxNumberOfDimensions {
257-
dpv.logger.Debug("dropping datapoint",
257+
dpv.logger.Warn("dropping datapoint",
258258
zap.String("reason", invalidNumberOfDimensions),
259259
zap.Stringer("datapoint", dp),
260260
zap.Int("number_of_dimensions", len(dp.Dimensions)),

0 commit comments

Comments
 (0)