Pull Request review changes for #27232

- Define "aws-api" as a const
- Rename some variables in cause.go to make the intended behavior a little more clear
- PR: #27232

Author: jknollmeyer

exporter/awsxrayexporter/internal/translator/cause.go

@@ -39,22 +39,23 @@ func makeCause(span ptrace.Span, attributes map[string]pcommon.Value, resource p
 	)
 
 	isAwsSdkSpan := isAwsSdkSpan(span)
-	hasExceptions := false
+	hasExceptionEvents := false
 	hasAwsIndividualHTTPError := false
 	for i := 0; i < span.Events().Len(); i++ {
 		event := span.Events().At(i)
 		if event.Name() == ExceptionEventName {
-			hasExceptions = true
+			hasExceptionEvents = true
 			break
 		}
 		if isAwsSdkSpan && event.Name() == AwsIndividualHTTPEventName {
 			hasAwsIndividualHTTPError = true
 			break
 		}
 	}
+	hasExceptions := hasExceptionEvents || hasAwsIndividualHTTPError
 
 	switch {
-	case hasExceptions || hasAwsIndividualHTTPError:
+	case hasExceptions:
 		language := ""
 		if val, ok := resource.Attributes().Get(conventions.AttributeTelemetrySDKLanguage); ok {
 			language = val.Str()

exporter/awsxrayexporter/internal/translator/segment.go

@@ -53,6 +53,8 @@ const (
 	defaultSegmentName = "span"
 	// maxSegmentNameLength the maximum length of a Segment name
 	maxSegmentNameLength = 200
+	// rpc.system value for AWS service remotes
+	awsAPIRPCSystem = "aws-api"
 )
 
 const (
@@ -82,7 +84,7 @@ func MakeSegmentDocumentString(span ptrace.Span, resource pcommon.Resource, inde
 func isAwsSdkSpan(span ptrace.Span) bool {
 	attributes := span.Attributes()
 	if rpcSystem, ok := attributes.Get(conventions.AttributeRPCSystem); ok {
-		return rpcSystem.Str() == "aws-api"
+		return rpcSystem.Str() == awsAPIRPCSystem
 	}
 	return false
 }