Removing Histograms and ALL, reverting metric name

Author: marcelbirkner

cmd/telemetrygen/internal/metrics/config.go

@@ -22,6 +22,6 @@ func (c *Config) Flags(fs *pflag.FlagSet) {
 	c.MetricType = metricTypeGauge
 
 	c.CommonFlags(fs)
-	fs.Var(&c.MetricType, "metric-type", "Metric type enum. must be one of 'gauge', 'sum', 'histogram' or 'all'")
+	fs.Var(&c.MetricType, "metric-type", "Metric type enum. must be one of 'Gauge' or 'Sum'")
 	fs.IntVar(&c.NumMetrics, "metrics", 1, "Number of metrics to generate in each worker (ignored if duration is provided)")
 }

cmd/telemetrygen/internal/metrics/metrics_types.go

@@ -7,10 +7,8 @@ import (
 type metricType string
 
 const (
-	metricTypeAll       metricType = "all"
-	metricTypeGauge     metricType = "gauge"
-	metricTypeHistogram metricType = "histogram"
-	metricTypeSum       metricType = "sum"
+	metricTypeGauge     = "Gauge"
+	metricTypeSum       = "Sum"
 )
 
 // String is used both by fmt.Print and by Cobra in help text
@@ -21,11 +19,11 @@ func (e *metricType) String() string {
 // Set must have pointer receiver so it doesn't change the value of a copy
 func (e *metricType) Set(v string) error {
 	switch v {
-	case "gauge", "sum", "histogram", "all":
+	case "Gauge", "Sum":
 		*e = metricType(v)
 		return nil
 	default:
-		return errors.New(`must be one of "gauge", "sum", "histogram" or "all"`)
+		return errors.New(`must be one of "Gauge" or "Sum"`)
 	}
 }
 

cmd/telemetrygen/internal/metrics/worker.go

@@ -33,9 +33,9 @@ func (w worker) simulateMetrics(res *resource.Resource, exporter sdkmetric.Expor
 	var i int64
 	for w.running.Load() {
 		var metrics []metricdata.Metrics
-		if w.metricType == metricTypeGauge || w.metricType == metricTypeAll {
+		if w.metricType == metricTypeGauge {
 			metrics = append(metrics, metricdata.Metrics{
-				Name: "gen.metric.gauge",
+				Name: "gen",
 				Data: metricdata.Gauge[int64]{
 					DataPoints: []metricdata.DataPoint[int64]{
 						{
@@ -45,9 +45,9 @@ func (w worker) simulateMetrics(res *resource.Resource, exporter sdkmetric.Expor
 					},
 				},
 			})
-		} else if w.metricType == metricTypeSum || w.metricType == metricTypeAll {
+		} else if w.metricType == metricTypeSum {
 			metrics = append(metrics, metricdata.Metrics{
-				Name: "gen.metric.sum",
+				Name: "gen",
 				Data: metricdata.Sum[int64]{
 					IsMonotonic: true,
 					Temporality: metricdata.DeltaTemporality,
@@ -60,22 +60,6 @@ func (w worker) simulateMetrics(res *resource.Resource, exporter sdkmetric.Expor
 					},
 				},
 			})
-		} else if w.metricType == metricTypeHistogram || w.metricType == metricTypeAll {
-			value := 24.42
-			metrics = append(metrics, metricdata.Metrics{
-				Name: "gen.metric.histogram",
-				Data: metricdata.Histogram[float64]{
-					Temporality: metricdata.CumulativeTemporality,
-					DataPoints: []metricdata.HistogramDataPoint[float64]{
-						{
-							Sum:   float64(float32(value)),
-							Max:   metricdata.NewExtrema(float64(float32(value))),
-							Min:   metricdata.NewExtrema(float64(float32(value))),
-							Count: 1,
-						},
-					},
-				},
-			})
 		} else {
 			w.logger.Fatal("unknown metric type")
 		}