Skip to content

Commit ba7aa1e

Browse files
committed
remove unused code
Signed-off-by: ChrsMark <[email protected]>
1 parent e460181 commit ba7aa1e

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

receiver/receivercreator/discovery.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,12 @@ const (
2828
configHint = "config"
2929
)
3030

31-
// hintsTemplatesBuilder creates configuration templates from provided hints.
32-
type hintsTemplatesBuilder interface {
33-
createReceiverTemplateFromHints(env observer.EndpointEnv) (*receiverTemplate, error)
34-
}
35-
3631
// k8sHintsBuilder creates configurations from hints provided as Pod's annotations.
3732
type k8sHintsBuilder struct {
3833
logger *zap.Logger
3934
ignoreReceivers map[string]bool
4035
}
4136

42-
var _ hintsTemplatesBuilder = (*k8sHintsBuilder)(nil)
43-
4437
func createK8sHintsBuilder(config DiscoveryConfig, logger *zap.Logger) k8sHintsBuilder {
4538
ignoreReceivers := make(map[string]bool, len(config.IgnoreReceivers))
4639
for _, r := range config.IgnoreReceivers {
@@ -202,15 +195,6 @@ func validateEndpoint(endpoint, defaultEndpoint string) error {
202195
}
203196
uri = u
204197
}
205-
// target endpoint can come in form ip:port. In that case we fix the uri
206-
// temporarily with adding http scheme
207-
if uri.Scheme == "" {
208-
u, err := url.Parse("http://" + endpoint)
209-
if err != nil {
210-
return fmt.Errorf("could not parse enpoint")
211-
}
212-
uri = u
213-
}
214198

215199
// configured endpoint should include the target Pod's endpoint
216200
if uri.Host != defaultEndpoint {

receiver/receivercreator/discovery_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,11 @@ func TestValidateEndpoint(t *testing.T) {
369369
defaultEndpoint: "1.2.3.4:8080",
370370
expectError: false,
371371
},
372+
"test_valid_no_scheme_no_path": {
373+
endpoint: "1.2.3.4:8080",
374+
defaultEndpoint: "1.2.3.4:8080",
375+
expectError: false,
376+
},
372377
"test_valid_no_scheme_dynamic": {
373378
endpoint: "`endpoint`/stats",
374379
defaultEndpoint: "1.2.3.4:8080",

0 commit comments

Comments
 (0)