Add more test cases

For negative buckets, and for a second datapoint with fewer instead of more bucket count array items
than the first.

Author: enisoc

internal/coreinternal/aggregateutil/aggregate_test.go

@@ -365,9 +365,10 @@ func Test_GroupDataPoints(t *testing.T) {
 				d := s.DataPoints().AppendEmpty()
 				d.SetTimestamp(pcommon.NewTimestampFromTime(time.Time{}))
 				d.Attributes().PutStr("attr1", "val1")
-				d.SetCount(8)
+				d.SetCount(9)
 				d.SetZeroCount(2)
 				d.Positive().BucketCounts().Append(0, 1, 2, 3)
+				d.Negative().BucketCounts().Append(0, 1)
 				return m
 			},
 			want: AggGroups{
@@ -485,10 +486,11 @@ func Test_MergeDataPoints(t *testing.T) {
 				s := m.SetEmptyExponentialHistogram()
 				d := s.DataPoints().AppendEmpty()
 				d.Attributes().PutStr("attr1", "val1")
-				d.SetCount(12)
+				d.SetCount(16)
 				d.SetSum(0)
 				d.SetZeroCount(3)
 				d.Positive().BucketCounts().Append(0, 2, 4, 3)
+				d.Negative().BucketCounts().Append(0, 2, 2)
 				return m
 			},
 			in: func() pmetric.Metric {
@@ -551,9 +553,10 @@ func testDataExpHistogram() pmetric.ExponentialHistogramDataPointSlice {
 	data := pmetric.NewExponentialHistogramDataPointSlice()
 	d := data.AppendEmpty()
 	d.Attributes().PutStr("attr1", "val1")
-	d.SetCount(4)
+	d.SetCount(7)
 	d.SetZeroCount(1)
 	d.Positive().BucketCounts().Append(0, 1, 2)
+	d.Negative().BucketCounts().Append(0, 1, 2)
 	return data
 }
 
@@ -562,18 +565,22 @@ func testDataExpHistogramDouble() pmetric.ExponentialHistogramDataPointSlice {
 
 	dWant := dataWant.AppendEmpty()
 	dWant.Attributes().PutStr("attr1", "val1")
-	dWant.SetCount(4)
+	dWant.SetCount(7)
 	dWant.SetZeroCount(1)
 	dWant.Positive().BucketCounts().Append(0, 1, 2)
+	dWant.Negative().BucketCounts().Append(0, 1, 2)
 
 	dWant2 := dataWant.AppendEmpty()
 	dWant2.SetTimestamp(pcommon.NewTimestampFromTime(time.Time{}))
 	dWant2.Attributes().PutStr("attr1", "val1")
-	dWant2.SetCount(8)
+	dWant2.SetCount(9)
 	dWant2.SetZeroCount(2)
 	// Use a larger number of buckets than above to check that we expand the
 	// destination array as needed while merging.
 	dWant2.Positive().BucketCounts().Append(0, 1, 2, 3)
+	// Use a smaller number of buckets than above to check that we merge values
+	// into the correct, existing buckets.
+	dWant2.Negative().BucketCounts().Append(0, 1)
 
 	return dataWant
 }