adapt to pr review

Signed-off-by: Florian Bacher <[email protected]>

Author: bacherfl

pkg/ottl/e2e/e2e_test.go

@@ -54,7 +54,6 @@ func Test_e2e_editors(t *testing.T) {
 				tCtx.GetLogRecord().Attributes().Remove("flags")
 				tCtx.GetLogRecord().Attributes().Remove("total.string")
 				tCtx.GetLogRecord().Attributes().Remove("foo")
-				tCtx.GetLogRecord().Attributes().Remove("double_value")
 			},
 		},
 		{
@@ -82,7 +81,6 @@ func Test_e2e_editors(t *testing.T) {
 				m.PutStr("test.foo.flags", "pass")
 				m.PutStr("test.foo.slice.0", "val")
 				m.PutStr("test.foo.nested.test", "pass")
-				m.PutDouble("test.double_value", 10.5)
 				m.CopyTo(tCtx.GetLogRecord().Attributes())
 			},
 		},
@@ -104,7 +102,6 @@ func Test_e2e_editors(t *testing.T) {
 				m.PutStr("foo.bar", "pass")
 				m.PutStr("foo.flags", "pass")
 				m.PutStr("foo.slice.0", "val")
-				m.PutDouble("double_value", 10.5)
 				m2 := m.PutEmptyMap("foo.nested")
 				m2.PutStr("test", "pass")
 				m.CopyTo(tCtx.GetLogRecord().Attributes())
@@ -117,7 +114,6 @@ func Test_e2e_editors(t *testing.T) {
 				tCtx.GetLogRecord().Attributes().Remove("http.path")
 				tCtx.GetLogRecord().Attributes().Remove("http.url")
 				tCtx.GetLogRecord().Attributes().Remove("foo")
-				tCtx.GetLogRecord().Attributes().Remove("double_value")
 			},
 		},
 		{
@@ -132,7 +128,6 @@ func Test_e2e_editors(t *testing.T) {
 				tCtx.GetLogRecord().Attributes().Remove("http.url")
 				tCtx.GetLogRecord().Attributes().Remove("flags")
 				tCtx.GetLogRecord().Attributes().Remove("foo")
-				tCtx.GetLogRecord().Attributes().Remove("double_value")
 			},
 		},
 		{
@@ -842,7 +837,6 @@ func constructLogTransformContext() ottllog.TransformContext {
 	logRecord.Attributes().PutStr("http.url", "http://localhost/health")
 	logRecord.Attributes().PutStr("flags", "A|B|C")
 	logRecord.Attributes().PutStr("total.string", "123456789")
-	logRecord.Attributes().PutDouble("double_value", 10.5)
 	m := logRecord.Attributes().PutEmptyMap("foo")
 	m.PutStr("bar", "pass")
 	m.PutStr("flags", "pass")

processor/transformprocessor/internal/metrics/func_scale.go

@@ -37,6 +37,15 @@ func Scale(args ScaleArguments) (ottl.ExprFunc[ottlmetric.TransformContext], err
 	return func(ctx context.Context, tCtx ottlmetric.TransformContext) (any, error) {
 		metric := tCtx.GetMetric()
 
+		var unit string
+		var err error
+		if !args.Unit.IsEmpty() {
+			unit, err = args.Unit.Get().Get(ctx, tCtx)
+			if err != nil {
+				return nil, fmt.Errorf("could not get unit from ScaleArguments: %w", err)
+			}
+		}
+
 		switch metric.Type() {
 		case pmetric.MetricTypeGauge:
 			scaleMetric(metric.Gauge().DataPoints(), args.Multiplier)
@@ -51,14 +60,10 @@ func Scale(args ScaleArguments) (ottl.ExprFunc[ottlmetric.TransformContext], err
 		default:
 			return nil, fmt.Errorf("unsupported metric type: '%v'", metric.Type())
 		}
-
 		if !args.Unit.IsEmpty() {
-			unit, err := args.Unit.Get().Get(ctx, tCtx)
-			if err != nil {
-				return nil, fmt.Errorf("could not get unit from ScaleArguments: %w", err)
-			}
 			metric.SetUnit(unit)
 		}
+
 		return nil, nil
 	}, nil
 }

processor/transformprocessor/internal/metrics/func_scale_test.go

@@ -114,6 +114,31 @@ func TestScale(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		{
+			name: "scale summary metric",
+			valueFunc: func() pmetric.Metric {
+				metric := pmetric.NewMetric()
+				dp := metric.SetEmptySummary().DataPoints().AppendEmpty()
+				dp.SetSum(10.0)
+				qv := dp.QuantileValues().AppendEmpty()
+				qv.SetValue(10.0)
+
+				return metric
+			},
+			args: ScaleArguments{
+				Multiplier: 10.0,
+			},
+			wantFunc: func() pmetric.Metric {
+				metric := pmetric.NewMetric()
+				dp := metric.SetEmptySummary().DataPoints().AppendEmpty()
+				dp.SetSum(100.0)
+				qv := dp.QuantileValues().AppendEmpty()
+				qv.SetValue(100.0)
+
+				return metric
+			},
+			wantErr: false,
+		},
 		{
 			name: "unsupported: exponential histogram metric",
 			valueFunc: func() pmetric.Metric {