Skip to content

Commit a045394

Browse files
committed
remove back 0.0
1 parent fede1cc commit a045394

File tree

8 files changed

+75
-73
lines changed

8 files changed

+75
-73
lines changed

exporter/logzioexporter/exporter.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ import (
1515
"strconv"
1616
"time"
1717

18-
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter/internal/dbmodel"
19-
2018
"github.com/hashicorp/go-hclog"
2119
"github.com/jaegertracing/jaeger/model"
2220
"github.com/jaegertracing/jaeger/pkg/cache"
@@ -191,7 +189,7 @@ func (exporter *logzioExporter) pushTraceData(ctx context.Context, traces ptrace
191189
span.Process = batch.Process
192190
span.Tags = exporter.dropEmptyTags(span.Tags)
193191
span.Process.Tags = exporter.dropEmptyTags(span.Process.Tags)
194-
logzioSpan, transformErr := dbmodel.TransformToLogzioSpanBytes(span)
192+
logzioSpan, transformErr := transformToLogzioSpanBytes(span)
195193
if transformErr != nil {
196194
return transformErr
197195
}

exporter/logzioexporter/exporter_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import (
1616
"testing"
1717
"time"
1818

19-
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter/internal/dbmodel"
20-
2119
"github.com/stretchr/testify/assert"
2220
"github.com/stretchr/testify/require"
2321
"go.opentelemetry.io/collector/component/componenttest"
@@ -257,7 +255,7 @@ func TestPushTraceData(tester *testing.T) {
257255
res.Attributes().PutStr(conventions.AttributeHostName, testHost)
258256
err := testTracesExporter(tester, td, &cfg)
259257
require.NoError(tester, err)
260-
var newSpan dbmodel.LogzioSpan
258+
var newSpan logzioSpan
261259
decoded, _ := gUnzipData(recordedRequests)
262260
requests := strings.Split(string(decoded), "\n")
263261
assert.NoError(tester, json.Unmarshal([]byte(requests[0]), &newSpan))
Lines changed: 30 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1+
// Copyright The OpenTelemetry Authors
12
// Copyright (c) 2019 The Jaeger Authors.
23
// Copyright (c) 2018 Uber Technologies, Inc.
34
// SPDX-License-Identifier: Apache-2.0
45

5-
package dbmodel // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter"
6+
package logzioexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter"
67

78
import (
89
"strings"
910

1011
"github.com/jaegertracing/jaeger/model"
12+
13+
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter/internal/dbmodel"
1114
)
1215

1316
// newFromDomain creates fromDomain used to convert model span to db span
@@ -28,15 +31,15 @@ type fromDomain struct {
2831

2932
// fromDomainEmbedProcess converts model.span into json.span format.
3033
// This format includes a ParentSpanID and an embedded process.
31-
func (fd fromDomain) fromDomainEmbedProcess(span *model.Span) *LogzioSpan {
34+
func (fd fromDomain) fromDomainEmbedProcess(span *model.Span) *logzioSpan {
3235
return fd.convertSpanEmbedProcess(span)
3336
}
3437

35-
func (fd fromDomain) convertSpanInternal(span *model.Span) LogzioSpan {
38+
func (fd fromDomain) convertSpanInternal(span *model.Span) logzioSpan {
3639
tags, tagsMap := fd.convertKeyValuesString(span.Tags)
37-
return LogzioSpan{
38-
TraceID: TraceID(span.TraceID.String()),
39-
SpanID: SpanID(span.SpanID.String()),
40+
return logzioSpan{
41+
TraceID: dbmodel.TraceID(span.TraceID.String()),
42+
SpanID: dbmodel.SpanID(span.SpanID.String()),
4043
Flags: uint32(span.Flags),
4144
OperationName: span.OperationName,
4245
StartTime: model.TimeAsEpochMicroseconds(span.StartTime),
@@ -48,35 +51,35 @@ func (fd fromDomain) convertSpanInternal(span *model.Span) LogzioSpan {
4851
}
4952
}
5053

51-
func (fd fromDomain) convertSpanEmbedProcess(span *model.Span) *LogzioSpan {
54+
func (fd fromDomain) convertSpanEmbedProcess(span *model.Span) *logzioSpan {
5255
s := fd.convertSpanInternal(span)
5356
s.Process = fd.convertProcess(span.Process)
5457
s.References = fd.convertReferences(span)
5558
return &s
5659
}
5760

58-
func (fd fromDomain) convertReferences(span *model.Span) []Reference {
59-
out := make([]Reference, 0, len(span.References))
61+
func (fd fromDomain) convertReferences(span *model.Span) []dbmodel.Reference {
62+
out := make([]dbmodel.Reference, 0, len(span.References))
6063
for _, ref := range span.References {
61-
out = append(out, Reference{
64+
out = append(out, dbmodel.Reference{
6265
RefType: fd.convertRefType(ref.RefType),
63-
TraceID: TraceID(ref.TraceID.String()),
64-
SpanID: SpanID(ref.SpanID.String()),
66+
TraceID: dbmodel.TraceID(ref.TraceID.String()),
67+
SpanID: dbmodel.SpanID(ref.SpanID.String()),
6568
})
6669
}
6770
return out
6871
}
6972

70-
func (fromDomain) convertRefType(refType model.SpanRefType) ReferenceType {
73+
func (fromDomain) convertRefType(refType model.SpanRefType) dbmodel.ReferenceType {
7174
if refType == model.FollowsFrom {
72-
return FollowsFrom
75+
return dbmodel.FollowsFrom
7376
}
74-
return ChildOf
77+
return dbmodel.ChildOf
7578
}
7679

77-
func (fd fromDomain) convertKeyValuesString(keyValues model.KeyValues) ([]KeyValue, map[string]any) {
80+
func (fd fromDomain) convertKeyValuesString(keyValues model.KeyValues) ([]dbmodel.KeyValue, map[string]any) {
7881
var tagsMap map[string]any
79-
var kvs []KeyValue
82+
var kvs []dbmodel.KeyValue
8083
for _, kv := range keyValues {
8184
if kv.GetVType() != model.BinaryType && (fd.allTagsAsFields || fd.tagKeysAsFields[kv.Key]) {
8285
if tagsMap == nil {
@@ -88,39 +91,39 @@ func (fd fromDomain) convertKeyValuesString(keyValues model.KeyValues) ([]KeyVal
8891
}
8992
}
9093
if kvs == nil {
91-
kvs = make([]KeyValue, 0)
94+
kvs = make([]dbmodel.KeyValue, 0)
9295
}
9396
return kvs, tagsMap
9497
}
9598

96-
func (fromDomain) convertLogs(logs []model.Log) []Log {
97-
out := make([]Log, len(logs))
99+
func (fromDomain) convertLogs(logs []model.Log) []dbmodel.Log {
100+
out := make([]dbmodel.Log, len(logs))
98101
for i, log := range logs {
99-
var kvs []KeyValue
102+
var kvs []dbmodel.KeyValue
100103
for _, kv := range log.Fields {
101104
kvs = append(kvs, convertKeyValue(kv))
102105
}
103-
out[i] = Log{
106+
out[i] = dbmodel.Log{
104107
Timestamp: model.TimeAsEpochMicroseconds(log.Timestamp),
105108
Fields: kvs,
106109
}
107110
}
108111
return out
109112
}
110113

111-
func (fd fromDomain) convertProcess(process *model.Process) Process {
114+
func (fd fromDomain) convertProcess(process *model.Process) dbmodel.Process {
112115
tags, tagsMap := fd.convertKeyValuesString(process.Tags)
113-
return Process{
116+
return dbmodel.Process{
114117
ServiceName: process.ServiceName,
115118
Tags: tags,
116119
Tag: tagsMap,
117120
}
118121
}
119122

120-
func convertKeyValue(kv model.KeyValue) KeyValue {
121-
return KeyValue{
123+
func convertKeyValue(kv model.KeyValue) dbmodel.KeyValue {
124+
return dbmodel.KeyValue{
122125
Key: kv.Key,
123-
Type: ValueType(strings.ToLower(kv.VType.String())),
126+
Type: dbmodel.ValueType(strings.ToLower(kv.VType.String())),
124127
Value: kv.AsString(),
125128
}
126129
}

exporter/logzioexporter/internal/dbmodel/from_domain_test.go renamed to exporter/logzioexporter/from_domain_test.go

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
// Copyright The OpenTelemetry Authors
12
// Copyright (c) 2019 The Jaeger Authors.
23
// Copyright (c) 2018 Uber Technologies, Inc.
34
// SPDX-License-Identifier: Apache-2.0
45

5-
package dbmodel
6+
package logzioexporter
67

78
import (
89
"bytes"
@@ -13,10 +14,11 @@ import (
1314
"testing"
1415

1516
"github.com/gogo/protobuf/jsonpb"
17+
"github.com/jaegertracing/jaeger/model"
1618
"github.com/stretchr/testify/assert"
1719
"github.com/stretchr/testify/require"
1820

19-
"github.com/jaegertracing/jaeger/model"
21+
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter/internal/dbmodel"
2022
)
2123

2224
func TestFromDomainEmbedProcess(t *testing.T) {
@@ -27,19 +29,17 @@ func TestFromDomainEmbedProcess(t *testing.T) {
2729
converter := newFromDomain(false, nil, ":")
2830
embeddedSpan := converter.fromDomainEmbedProcess(&span)
2931

30-
var expectedSpan LogzioSpan
32+
var expectedSpan logzioSpan
3133
require.NoError(t, json.Unmarshal(jsonStr, &expectedSpan))
3234

3335
testJSONEncoding(t, jsonStr, embeddedSpan)
3436
}
3537

3638
// Loads and returns domain model and JSON model.
3739
func loadModel(t *testing.T) ([]byte, []byte) {
38-
in := fmt.Sprintf("../../testdata/span.json")
39-
inStr, err := os.ReadFile(in)
40+
inStr, err := os.ReadFile("./testdata/span.json")
4041
require.NoError(t, err)
41-
out := fmt.Sprintf("../../testdata/logziospan.json")
42-
outStr, err := os.ReadFile(out)
42+
outStr, err := os.ReadFile("./testdata/logziospan.json")
4343
require.NoError(t, err)
4444
return inStr, outStr
4545
}
@@ -50,7 +50,7 @@ func testJSONEncoding(t *testing.T, expectedStr []byte, object any) {
5050
enc.SetIndent("", " ")
5151
require.NoError(t, enc.Encode(object))
5252
if !assert.Equal(t, string(expectedStr), buf.String()) {
53-
err := os.WriteFile("model-actual.json", buf.Bytes(), 0o644)
53+
err := os.WriteFile("model-actual.json", buf.Bytes(), 0o600)
5454
require.NoError(t, err)
5555
}
5656
}
@@ -95,35 +95,35 @@ func TestConvertKeyValueValue(t *testing.T) {
9595
key := "key"
9696
tests := []struct {
9797
kv model.KeyValue
98-
expected KeyValue
98+
expected dbmodel.KeyValue
9999
}{
100100
{
101101
kv: model.Bool(key, true),
102-
expected: KeyValue{Key: key, Value: "true", Type: "bool"},
102+
expected: dbmodel.KeyValue{Key: key, Value: "true", Type: "bool"},
103103
},
104104
{
105105
kv: model.Bool(key, false),
106-
expected: KeyValue{Key: key, Value: "false", Type: "bool"},
106+
expected: dbmodel.KeyValue{Key: key, Value: "false", Type: "bool"},
107107
},
108108
{
109109
kv: model.Int64(key, int64(1499)),
110-
expected: KeyValue{Key: key, Value: "1499", Type: "int64"},
110+
expected: dbmodel.KeyValue{Key: key, Value: "1499", Type: "int64"},
111111
},
112112
{
113113
kv: model.Float64(key, float64(15.66)),
114-
expected: KeyValue{Key: key, Value: "15.66", Type: "float64"},
114+
expected: dbmodel.KeyValue{Key: key, Value: "15.66", Type: "float64"},
115115
},
116116
{
117117
kv: model.String(key, longString),
118-
expected: KeyValue{Key: key, Value: longString, Type: "string"},
118+
expected: dbmodel.KeyValue{Key: key, Value: longString, Type: "string"},
119119
},
120120
{
121121
kv: model.Binary(key, []byte(longString)),
122-
expected: KeyValue{Key: key, Value: hex.EncodeToString([]byte(longString)), Type: "binary"},
122+
expected: dbmodel.KeyValue{Key: key, Value: hex.EncodeToString([]byte(longString)), Type: "binary"},
123123
},
124124
{
125125
kv: model.KeyValue{VType: 1500, Key: key},
126-
expected: KeyValue{Key: key, Value: "unknown type 1500", Type: "1500"},
126+
expected: dbmodel.KeyValue{Key: key, Value: "unknown type 1500", Type: "1500"},
127127
},
128128
}
129129

exporter/logzioexporter/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzio
33
go 1.22.0
44

55
require (
6-
github.com/gogo/protobuf v1.3.2
76
github.com/hashicorp/go-hclog v1.6.3
87
github.com/jaegertracing/jaeger v1.62.0
98
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger v0.116.0
@@ -37,6 +36,7 @@ require (
3736
github.com/go-logr/logr v1.4.2 // indirect
3837
github.com/go-logr/stdr v1.2.2 // indirect
3938
github.com/go-viper/mapstructure/v2 v2.2.1 // indirect
39+
github.com/gogo/protobuf v1.3.2 // indirect
4040
github.com/golang/snappy v0.0.4 // indirect
4141
github.com/google/uuid v1.6.0 // indirect
4242
github.com/hashicorp/go-version v1.7.0 // indirect

exporter/logzioexporter/internal/dbmodel/model.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
// Copyright The OpenTelemetry Authors
12
// Copyright (c) 2019 The Jaeger Authors.
23
// Copyright (c) 2018 Uber Technologies, Inc.
34
// SPDX-License-Identifier: Apache-2.0
45

5-
package dbmodel
6+
package dbmodel // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter/internal/dbmodel"
67

78
// ReferenceType is the reference type of one span to another
89
type ReferenceType string

exporter/logzioexporter/internal/dbmodel/logziospan.go renamed to exporter/logzioexporter/logziospan.go

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
package dbmodel // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter"
4+
package logzioexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter"
55

66
import (
77
"encoding/json"
88

99
"github.com/jaegertracing/jaeger/model"
10+
11+
"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/logzioexporter/internal/dbmodel"
1012
)
1113

1214
const (
@@ -15,22 +17,22 @@ const (
1517
tagDotReplacementCharacter = "@"
1618
)
1719

18-
// LogzioSpan is same as esSpan with a few different json field names and an addition on type field.
19-
type LogzioSpan struct {
20-
TraceID TraceID `json:"traceID"`
21-
OperationName string `json:"operationName,omitempty"`
22-
SpanID SpanID `json:"spanID"`
23-
References []Reference `json:"references"`
24-
Flags uint32 `json:"flags,omitempty"`
25-
StartTime uint64 `json:"startTime"`
26-
StartTimeMillis uint64 `json:"startTimeMillis"`
27-
Timestamp uint64 `json:"@timestamp"`
28-
Duration uint64 `json:"duration"`
29-
Tags []KeyValue `json:"JaegerTags,omitempty"`
30-
Tag map[string]any `json:"JaegerTag,omitempty"`
31-
Logs []Log `json:"logs"`
32-
Process Process `json:"process,omitempty"`
33-
Type string `json:"type"`
20+
// logzioSpan is same as esSpan with a few different json field names and an addition on type field.
21+
type logzioSpan struct {
22+
TraceID dbmodel.TraceID `json:"traceID"`
23+
OperationName string `json:"operationName,omitempty"`
24+
SpanID dbmodel.SpanID `json:"spanID"`
25+
References []dbmodel.Reference `json:"references"`
26+
Flags uint32 `json:"flags,omitempty"`
27+
StartTime uint64 `json:"startTime"`
28+
StartTimeMillis uint64 `json:"startTimeMillis"`
29+
Timestamp uint64 `json:"@timestamp"`
30+
Duration uint64 `json:"duration"`
31+
Tags []dbmodel.KeyValue `json:"JaegerTags,omitempty"`
32+
Tag map[string]any `json:"JaegerTag,omitempty"`
33+
Logs []dbmodel.Log `json:"logs"`
34+
Process dbmodel.Process `json:"process,omitempty"`
35+
Type string `json:"type"`
3436
}
3537

3638
func getTagsValues(tags []model.KeyValue) []string {
@@ -43,10 +45,10 @@ func getTagsValues(tags []model.KeyValue) []string {
4345

4446
// transformToLogzioSpanBytes receives a Jaeger span, converts it to logzio span and returns it as a byte array.
4547
// The main differences between Jaeger span and logzio span are arrays which are represented as maps
46-
func TransformToLogzioSpanBytes(span *model.Span) ([]byte, error) {
48+
func transformToLogzioSpanBytes(span *model.Span) ([]byte, error) {
4749
spanConverter := newFromDomain(true, getTagsValues(span.Tags), tagDotReplacementCharacter)
4850
jsonSpan := spanConverter.fromDomainEmbedProcess(span)
49-
newSpan := LogzioSpan{
51+
newSpan := logzioSpan{
5052
TraceID: jsonSpan.TraceID,
5153
OperationName: jsonSpan.OperationName,
5254
SpanID: jsonSpan.SpanID,

exporter/logzioexporter/internal/dbmodel/logziospan_test.go renamed to exporter/logzioexporter/logziospan_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
package dbmodel
4+
package logzioexporter
55

66
import (
77
"encoding/json"
@@ -14,15 +14,15 @@ import (
1414
)
1515

1616
func TestTransformToLogzioSpanBytes(tester *testing.T) {
17-
inStr, err := os.ReadFile("../../testdata/span.json")
17+
inStr, err := os.ReadFile("./testdata/span.json")
1818
require.NoError(tester, err, "error opening sample span file")
1919

2020
var span model.Span
2121
err = json.Unmarshal(inStr, &span)
2222
if err != nil {
2323
fmt.Println("json.Unmarshal")
2424
}
25-
newSpan, err := TransformToLogzioSpanBytes(&span)
25+
newSpan, err := transformToLogzioSpanBytes(&span)
2626
require.NoError(tester, err)
2727
m := make(map[string]any)
2828
err = json.Unmarshal(newSpan, &m)

0 commit comments

Comments
 (0)