Skip to content

Commit 99764f5

Browse files
authored
[cmd/telemetrygen] fix status-code args default value (#25889)
Fix #25849 after adding more logs for failed telemetrygen pod, I found traces-job keeps failing with the error log ``` Error: expected `status-code` to be one of (Unset, Error, Ok) or (0, 1, 2), got "Unset" instead ``` here is a failed run https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5899236967/job/16005926116 I thinks this bug is brought in by the pr #24673 , the default value `Unset` for arg `status-code` is not a legal one, the legal one is `"Unset"` --------- Signed-off-by: Ziqi Zhao <[email protected]>
1 parent 8ca9449 commit 99764f5

File tree

2 files changed

+28
-1
lines changed

2 files changed

+28
-1
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: cmd/telemetrygen
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: fix the default value of the arg status-code
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [25849]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

cmd/telemetrygen/internal/traces/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func (c *Config) Flags(fs *pflag.FlagSet) {
2626
fs.IntVar(&c.NumTraces, "traces", 1, "Number of traces to generate in each worker (ignored if duration is provided)")
2727
fs.BoolVar(&c.PropagateContext, "marshal", false, "Whether to marshal trace context via HTTP headers")
2828
fs.StringVar(&c.ServiceName, "service", "telemetrygen", "Service name to use")
29-
fs.StringVar(&c.StatusCode, "status-code", "Unset", "Status code to use for the spans, one of (Unset, Error, Ok) or the equivalent integer (0,1,2)")
29+
fs.StringVar(&c.StatusCode, "status-code", "0", "Status code to use for the spans, one of (Unset, Error, Ok) or the equivalent integer (0,1,2)")
3030
fs.BoolVar(&c.Batch, "batch", true, "Whether to batch traces")
3131
fs.IntVar(&c.LoadSize, "size", 0, "Desired minimum size in MB of string data for each trace generated. This can be used to test traces with large payloads, i.e. when testing the OTLP receiver endpoint max receive size.")
3232
}

0 commit comments

Comments
 (0)