[pkg/ottl] Add StandardFuncs and StandardConverters to ottlfuncs (#23190)

* Add StandardFuncs and StandardConverters to ottlfuncs

* changelog

* add license

* make goporto

* update changelog

Author: TylerHelmuth

.chloggen/ottl-standard-functions.yaml

@@ -0,0 +1,20 @@
+# Use this changelog template to create an entry for release notes.
+# If your change doesn't affect end users, such as a test fix or a tooling change,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: pkg/ottl
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Adds `StandardFuncs` and `StandardConverters` to facilitate function map generation.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [23190]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext: This change means that new functions added to ottlfuncs get automatically added to Cotnrib components that use OTTL

internal/filter/filterottl/filter.go

@@ -152,20 +152,10 @@ func StandardLogFuncs() map[string]ottl.Factory[ottllog.TransformContext] {
 }
 
 func standardFuncs[K any]() map[string]ottl.Factory[K] {
-	return ottl.CreateFactoryMap(
-		ottlfuncs.NewTraceIDFactory[K](),
-		ottlfuncs.NewSpanIDFactory[K](),
-		ottlfuncs.NewIsMatchFactory[K](),
-		ottlfuncs.NewConcatFactory[K](),
-		ottlfuncs.NewSplitFactory[K](),
-		ottlfuncs.NewIntFactory[K](),
-		ottlfuncs.NewConvertCaseFactory[K](),
-		ottlfuncs.NewSubstringFactory[K](),
-		ottlfuncs.NewLogFactory[K](),
-		ottlfuncs.NewUUIDFactory[K](),
-		ottlfuncs.NewParseJSONFactory[K](),
-		newDropFactory[K](),
-	)
+	m := ottlfuncs.StandardConverters[K]()
+	f := newDropFactory[K]()
+	m[f.Name()] = f
+	return m
 }
 
 func newDropFactory[K any]() ottl.Factory[K] {

pkg/ottl/ottlfuncs/functions.go

@@ -0,0 +1,52 @@
+// Copyright The OpenTelemetry Authors
+// SPDX-License-Identifier: Apache-2.0
+
+package ottlfuncs // import "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
+
+import (
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl"
+)
+
+func StandardFuncs[K any]() map[string]ottl.Factory[K] {
+	f := []ottl.Factory[K]{
+		// Editors
+		NewDeleteKeyFactory[K](),
+		NewDeleteMatchingKeysFactory[K](),
+		NewKeepKeysFactory[K](),
+		NewLimitFactory[K](),
+		NewMergeMapsFactory[K](),
+		NewReplaceAllMatchesFactory[K](),
+		NewReplaceAllPatternsFactory[K](),
+		NewReplaceMatchFactory[K](),
+		NewReplacePatternFactory[K](),
+		NewSetFactory[K](),
+		NewTruncateAllFactory[K](),
+	}
+	f = append(f, converters[K]()...)
+
+	return ottl.CreateFactoryMap(f...)
+}
+
+func StandardConverters[K any]() map[string]ottl.Factory[K] {
+	return ottl.CreateFactoryMap(converters[K]()...)
+}
+
+func converters[K any]() []ottl.Factory[K] {
+	return []ottl.Factory[K]{
+		// Converters
+		NewConcatFactory[K](),
+		NewConvertCaseFactory[K](),
+		NewFnvFactory[K](),
+		NewIntFactory[K](),
+		NewIsMatchFactory[K](),
+		NewLogFactory[K](),
+		NewParseJSONFactory[K](),
+		NewSHA1Factory[K](),
+		NewSHA256Factory[K](),
+		NewSpanIDFactory[K](),
+		NewSplitFactory[K](),
+		NewSubstringFactory[K](),
+		NewTraceIDFactory[K](),
+		NewUUIDFactory[K](),
+	}
+}

processor/transformprocessor/internal/common/functions.go

@@ -10,36 +10,10 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
 )
 
-func Functions[K any]() map[string]ottl.Factory[K] {
-	return ottl.CreateFactoryMap(
-		ottlfuncs.NewTraceIDFactory[K](),
-		ottlfuncs.NewSpanIDFactory[K](),
-		ottlfuncs.NewIsMatchFactory[K](),
-		ottlfuncs.NewConcatFactory[K](),
-		ottlfuncs.NewSplitFactory[K](),
-		ottlfuncs.NewIntFactory[K](),
-		ottlfuncs.NewConvertCaseFactory[K](),
-		ottlfuncs.NewParseJSONFactory[K](),
-		ottlfuncs.NewSubstringFactory[K](),
-		ottlfuncs.NewKeepKeysFactory[K](),
-		ottlfuncs.NewSetFactory[K](),
-		ottlfuncs.NewTruncateAllFactory[K](),
-		ottlfuncs.NewLimitFactory[K](),
-		ottlfuncs.NewReplaceMatchFactory[K](),
-		ottlfuncs.NewReplaceAllMatchesFactory[K](),
-		ottlfuncs.NewReplacePatternFactory[K](),
-		ottlfuncs.NewReplaceAllPatternsFactory[K](),
-		ottlfuncs.NewDeleteKeyFactory[K](),
-		ottlfuncs.NewDeleteMatchingKeysFactory[K](),
-		ottlfuncs.NewMergeMapsFactory[K](),
-		ottlfuncs.NewLogFactory[K](),
-	)
-}
-
 func ResourceFunctions() map[string]ottl.Factory[ottlresource.TransformContext] {
-	return Functions[ottlresource.TransformContext]()
+	return ottlfuncs.StandardFuncs[ottlresource.TransformContext]()
 }
 
 func ScopeFunctions() map[string]ottl.Factory[ottlscope.TransformContext] {
-	return Functions[ottlscope.TransformContext]()
+	return ottlfuncs.StandardFuncs[ottlscope.TransformContext]()
 }

processor/transformprocessor/internal/logs/functions.go

@@ -6,10 +6,10 @@ package logs // import "github.com/open-telemetry/opentelemetry-collector-contri
 import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottllog"
-	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor/internal/common"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
 )
 
 func LogFunctions() map[string]ottl.Factory[ottllog.TransformContext] {
 	// No logs-only functions yet.
-	return common.Functions[ottllog.TransformContext]()
+	return ottlfuncs.StandardFuncs[ottllog.TransformContext]()
 }

processor/transformprocessor/internal/logs/functions_test.go

@@ -10,11 +10,11 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottllog"
-	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor/internal/common"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
 )
 
 func Test_LogFunctions(t *testing.T) {
-	expected := common.Functions[ottllog.TransformContext]()
+	expected := ottlfuncs.StandardFuncs[ottllog.TransformContext]()
 	actual := LogFunctions()
 	require.Equal(t, len(expected), len(actual))
 	for k := range actual {

processor/transformprocessor/internal/metrics/functions.go

@@ -7,11 +7,11 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottldatapoint"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottlmetric"
-	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor/internal/common"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
 )
 
 func DataPointFunctions() map[string]ottl.Factory[ottldatapoint.TransformContext] {
-	functions := common.Functions[ottldatapoint.TransformContext]()
+	functions := ottlfuncs.StandardFuncs[ottldatapoint.TransformContext]()
 
 	datapointFunctions := ottl.CreateFactoryMap[ottldatapoint.TransformContext](
 		newConvertSumToGaugeFactory(),
@@ -28,5 +28,5 @@ func DataPointFunctions() map[string]ottl.Factory[ottldatapoint.TransformContext
 }
 
 func MetricFunctions() map[string]ottl.Factory[ottlmetric.TransformContext] {
-	return common.Functions[ottlmetric.TransformContext]()
+	return ottlfuncs.StandardFuncs[ottlmetric.TransformContext]()
 }

processor/transformprocessor/internal/metrics/functions_test.go

@@ -11,11 +11,11 @@ import (
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottldatapoint"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottlmetric"
-	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor/internal/common"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
 )
 
 func Test_DataPointFunctions(t *testing.T) {
-	expected := common.Functions[ottldatapoint.TransformContext]()
+	expected := ottlfuncs.StandardFuncs[ottldatapoint.TransformContext]()
 	expected["convert_sum_to_gauge"] = newConvertSumToGaugeFactory()
 	expected["convert_gauge_to_sum"] = newConvertGaugeToSumFactory()
 	expected["convert_summary_sum_val_to_sum"] = newConvertSummarySumValToSumFactory()
@@ -30,7 +30,7 @@ func Test_DataPointFunctions(t *testing.T) {
 }
 
 func Test_MetricFunctions(t *testing.T) {
-	expected := common.Functions[ottlmetric.TransformContext]()
+	expected := ottlfuncs.StandardFuncs[ottlmetric.TransformContext]()
 	actual := MetricFunctions()
 	require.Equal(t, len(expected), len(actual))
 	for k := range actual {

processor/transformprocessor/internal/traces/functions.go

@@ -7,15 +7,15 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottlspan"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottlspanevent"
-	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor/internal/common"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
 )
 
 func SpanFunctions() map[string]ottl.Factory[ottlspan.TransformContext] {
 	// No trace-only functions yet.
-	return common.Functions[ottlspan.TransformContext]()
+	return ottlfuncs.StandardFuncs[ottlspan.TransformContext]()
 }
 
 func SpanEventFunctions() map[string]ottl.Factory[ottlspanevent.TransformContext] {
 	// No trace-only functions yet.
-	return common.Functions[ottlspanevent.TransformContext]()
+	return ottlfuncs.StandardFuncs[ottlspanevent.TransformContext]()
 }

processor/transformprocessor/internal/traces/functions_test.go

@@ -11,11 +11,11 @@ import (
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottlspan"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/contexts/ottlspanevent"
-	"github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor/internal/common"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/ottlfuncs"
 )
 
 func Test_SpanFunctions(t *testing.T) {
-	expected := common.Functions[ottlspan.TransformContext]()
+	expected := ottlfuncs.StandardFuncs[ottlspan.TransformContext]()
 	actual := SpanFunctions()
 	require.Equal(t, len(expected), len(actual))
 	for k := range actual {
@@ -24,7 +24,7 @@ func Test_SpanFunctions(t *testing.T) {
 }
 
 func Test_SpanEventFunctions(t *testing.T) {
-	expected := common.Functions[ottlspanevent.TransformContext]()
+	expected := ottlfuncs.StandardFuncs[ottlspanevent.TransformContext]()
 	actual := SpanEventFunctions()
 	require.Equal(t, len(expected), len(actual))
 	for k := range actual {