Commit 8abefcc
authored
[chore] Fix make for-all command (#43572)
#### Description
#43509 changed the `make for-all` Makefile target to access the
`ALL_MODS` variable through environment variables instead of expanding
it into the shell command, in order to bypass Windows' 8192 byte command
line length limit.
However, the environment variable was not defined, which led to `make
for-all` becoming a no-op. This can be confirmed by running `make
for-all CMD='echo test'`.
(I discovered this issue because [this
PR](open-telemetry/opentelemetry-collector#13996)
in core repository, which should be failing `contrib-tests`, suddenly
started passing them. This was because the job inserts `replace`
statements in a copy of contrib using `for-all`; failing to do that
caused the contrib tests to run against whatever version of core is
imported here rather than against the PR's code.)
This PR fixes that oversight, by adding the `export` keyword to the
`ALL_MODS` variable.1 parent 05a0c24 commit 8abefcc
File tree
4 files changed
+26
-26
lines changed- receiver/ciscoosreceiver
- internal/metadata
4 files changed
+26
-26
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
| 225 | + | |
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments