Skip to content

Commit 86827bc

Browse files
committed
Nil check named pipe shutdowns
When the `Start` method of the named pipe is called, it will create a new named pipe and start listening for connections. If that Start method _fails_ for any reason, some parts of the named pipe will not be initialized. This means that when the `Stop` method is called (as the collector does when `Start` fails), it will panic with a nil pointer dereference. This change adds a couple of nil checks to the `Stop` method to prevent this panic, because otherwise we just get the SIGSEGV signal, and we never get any error logs. Signed-off-by: sinkingpoint <[email protected]>
1 parent b90d987 commit 86827bc

File tree

2 files changed

+35
-2
lines changed

2 files changed

+35
-2
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: namedpipereceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Fix SIGSEGV when named pipe creation fails
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [31088]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

pkg/stanza/operator/input/namedpipe/namedpipe.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,14 @@ func (n *Input) Start(_ operator.Persister) error {
134134
}
135135

136136
func (n *Input) Stop() error {
137-
n.pipe.Close()
138-
n.cancel()
137+
if n.pipe != nil {
138+
n.pipe.Close()
139+
}
140+
141+
if n.cancel != nil {
142+
n.cancel()
143+
}
144+
139145
n.wg.Wait()
140146
return nil
141147
}

0 commit comments

Comments
 (0)