Skip to content

Commit 56a5899

Browse files
authored
Merge branch 'main' into tsp-late-span-age
2 parents b3716a6 + 7fd7054 commit 56a5899

File tree

23 files changed

+182
-180
lines changed

23 files changed

+182
-180
lines changed

.chloggen/eks_cloud_account_id.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: resourcedetectionprocessor
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: This enhancement detects AWS EKS cloud account ID
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [37179]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [user]

.chloggen/fg_filelog_stable.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: pkg/stanza
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Move `filelog.container.removeOriginalTimeField` feature gate to stable
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [33389]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [user]

exporter/datasetexporter/config_test.go

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import (
99
"time"
1010

1111
"github.com/stretchr/testify/assert"
12-
"go.opentelemetry.io/collector/config/configretry"
1312
"go.opentelemetry.io/collector/confmap"
14-
"go.opentelemetry.io/collector/exporter/exporterhelper"
1513
)
1614

1715
func TestConfigUnmarshalUnknownAttributes(t *testing.T) {
@@ -102,49 +100,6 @@ func TestConfigValidate(t *testing.T) {
102100
}
103101
}
104102

105-
func TestConfigString(t *testing.T) {
106-
config := Config{
107-
DatasetURL: "https://example.com",
108-
APIKey: "secret",
109-
Debug: true,
110-
BufferSettings: BufferSettings{
111-
MaxLifetime: 123,
112-
PurgeOlderThan: 567,
113-
GroupBy: []string{"field1", "field2"},
114-
},
115-
TracesSettings: TracesSettings{
116-
exportSettings: exportSettings{
117-
ExportSeparator: "TTT",
118-
ExportDistinguishingSuffix: "UUU",
119-
},
120-
},
121-
LogsSettings: LogsSettings{
122-
ExportResourceInfo: true,
123-
ExportResourcePrefix: "AAA",
124-
ExportScopeInfo: true,
125-
ExportScopePrefix: "BBB",
126-
DecomposeComplexMessageField: true,
127-
DecomposedComplexMessagePrefix: "EEE",
128-
exportSettings: exportSettings{
129-
ExportSeparator: "CCC",
130-
ExportDistinguishingSuffix: "DDD",
131-
},
132-
},
133-
ServerHostSettings: ServerHostSettings{
134-
ServerHost: "foo-bar",
135-
UseHostName: false,
136-
},
137-
BackOffConfig: configretry.NewDefaultBackOffConfig(),
138-
QueueSettings: exporterhelper.NewDefaultQueueConfig(),
139-
TimeoutSettings: exporterhelper.NewDefaultTimeoutConfig(),
140-
}
141-
142-
assert.Equal(t,
143-
"DatasetURL: https://example.com; APIKey: [REDACTED] (6); Debug: true; BufferSettings: {MaxLifetime:123ns PurgeOlderThan:567ns GroupBy:[field1 field2] RetryInitialInterval:0s RetryMaxInterval:0s RetryMaxElapsedTime:0s RetryShutdownTimeout:0s MaxParallelOutgoing:0}; LogsSettings: {ExportResourceInfo:true ExportResourcePrefix:AAA ExportScopeInfo:true ExportScopePrefix:BBB DecomposeComplexMessageField:true DecomposedComplexMessagePrefix:EEE exportSettings:{ExportSeparator:CCC ExportDistinguishingSuffix:DDD}}; TracesSettings: {exportSettings:{ExportSeparator:TTT ExportDistinguishingSuffix:UUU}}; ServerHostSettings: {UseHostName:false ServerHost:foo-bar}; BackOffConfig: {Enabled:true InitialInterval:5s RandomizationFactor:0.5 Multiplier:1.5 MaxInterval:30s MaxElapsedTime:5m0s}; QueueSettings: {Enabled:true NumConsumers:10 QueueSize:1000 StorageID:<nil>}; TimeoutSettings: {Timeout:5s}",
144-
config.String(),
145-
)
146-
}
147-
148103
func TestConfigUseProvidedExportResourceInfoValue(t *testing.T) {
149104
f := NewFactory()
150105
config := f.CreateDefaultConfig().(*Config)

exporter/tencentcloudlogserviceexporter/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ require (
66
github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal v0.117.0
77
github.com/pierrec/lz4 v2.6.1+incompatible
88
github.com/stretchr/testify v1.10.0
9-
github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common v1.0.1081
9+
github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common v1.0.1082
1010
go.opentelemetry.io/collector/component v0.117.1-0.20250114172347-71aae791d7f8
1111
go.opentelemetry.io/collector/component/componenttest v0.117.1-0.20250114172347-71aae791d7f8
1212
go.opentelemetry.io/collector/config/configopaque v1.23.1-0.20250114172347-71aae791d7f8

exporter/tencentcloudlogserviceexporter/go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extension/encoding/avrologencodingextension/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/extension/encod
33
go 1.22.0
44

55
require (
6-
github.com/linkedin/goavro/v2 v2.13.0
6+
github.com/linkedin/goavro/v2 v2.13.1
77
github.com/open-telemetry/opentelemetry-collector-contrib/extension/encoding v0.117.0
88
github.com/stretchr/testify v1.10.0
99
go.opentelemetry.io/collector/component v0.117.1-0.20250114172347-71aae791d7f8

extension/encoding/avrologencodingextension/go.sum

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/stanza/docs/operators/container.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -320,10 +320,3 @@ receivers:
320320
</td>
321321
</tr>
322322
</table>
323-
324-
### Removing original time field
325-
326-
In order to remove the original time field from the log records users can enable the
327-
`filelog.container.removeOriginalTimeField` feature gate.
328-
The feature gate `filelog.container.removeOriginalTimeField` will be deprecated and eventually removed
329-
in the future, following the [feature lifecycle](https://github.com/open-telemetry/opentelemetry-collector/tree/main/featuregate#feature-lifecycle).

pkg/stanza/operator/parser/container/config.go

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99

1010
"go.opentelemetry.io/collector/component"
1111
"go.opentelemetry.io/collector/featuregate"
12-
"go.uber.org/zap"
1312

1413
"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/entry"
1514
"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/errors"
@@ -25,11 +24,13 @@ const (
2524
removeOriginalTimeFieldFeatureFlag = "filelog.container.removeOriginalTimeField"
2625
)
2726

28-
var removeOriginalTimeField = featuregate.GlobalRegistry().MustRegister(
27+
var _ = featuregate.GlobalRegistry().MustRegister(
2928
removeOriginalTimeFieldFeatureFlag,
30-
featuregate.StageBeta,
29+
featuregate.StageStable,
3130
featuregate.WithRegisterDescription("When enabled, deletes the original `time` field from the Log Attributes. Time is parsed to Timestamp field, which should be used instead."),
3231
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/33389"),
32+
featuregate.WithRegisterFromVersion("v0.105.0"),
33+
featuregate.WithRegisterToVersion("v0.118.0"),
3334
)
3435

3536
func init() {
@@ -79,14 +80,6 @@ func (c Config) Build(set component.TelemetrySettings) (operator.Operator, error
7980
}
8081
}
8182

82-
if !removeOriginalTimeField.IsEnabled() {
83-
// https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/33389
84-
set.Logger.Info("`time` log record attribute will be removed in a future release. Switch now using the feature gate.",
85-
zap.String("attribute", "time"),
86-
zap.String("feature gate", removeOriginalTimeFieldFeatureFlag),
87-
)
88-
}
89-
9083
wg := sync.WaitGroup{}
9184

9285
p := &Parser{

pkg/stanza/operator/parser/container/parser.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -343,9 +343,7 @@ func parseTime(e *entry.Entry, layout string) error {
343343
// timeutils.ParseGotime calls timeutils.SetTimestampYear before returning the timeValue
344344
e.Timestamp = timeValue
345345

346-
if removeOriginalTimeField.IsEnabled() {
347-
e.Delete(entry.NewAttributeField(parseFrom))
348-
}
346+
e.Delete(entry.NewAttributeField(parseFrom))
349347

350348
return nil
351349
}

0 commit comments

Comments
 (0)