[processor/filterprocessor] reduce exposed Go API (#24845)

Unexport constants that were exposed as part of the configuration of the
processor.

Author: atoulme

.chloggen/unexport-filterprocessor.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: filterprocessor
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Unexport `Strict` and `Regexp`
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [24845]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

processor/filterprocessor/config.go

@@ -50,7 +50,7 @@ type MetricFilters struct {
 	// If both Include and Exclude are specified, Include filtering occurs first.
 	Exclude *filterconfig.MetricMatchProperties `mapstructure:"exclude"`
 
-	// RegexpConfig specifies options for the Regexp match type
+	// RegexpConfig specifies options for the regexp match type
 	RegexpConfig *regexp.Config `mapstructure:"regexp"`
 
 	// MetricConditions is a list of OTTL conditions for an ottlmetric context.
@@ -100,8 +100,8 @@ type LogMatchType string
 // These are the MatchTypes that users can specify for filtering
 // `plog.Log`s.
 const (
-	Strict = LogMatchType(filterset.Strict)
-	Regexp = LogMatchType(filterset.Regexp)
+	strictType = LogMatchType(filterset.Strict)
+	regexpType = LogMatchType(filterset.Regexp)
 )
 
 var severityToNumber = map[string]plog.SeverityNumber{

processor/filterprocessor/config_test.go

@@ -99,7 +99,7 @@ func TestLoadingConfigStrict(t *testing.T) {
 func TestLoadingConfigStrictLogs(t *testing.T) {
 
 	testDataLogPropertiesInclude := &LogMatchProperties{
-		LogMatchType: Strict,
+		LogMatchType: strictType,
 		ResourceAttributes: []filterconfig.Attribute{
 			{
 				Key:   "should_include",
@@ -109,7 +109,7 @@ func TestLoadingConfigStrictLogs(t *testing.T) {
 	}
 
 	testDataLogPropertiesExclude := &LogMatchProperties{
-		LogMatchType: Strict,
+		LogMatchType: strictType,
 		ResourceAttributes: []filterconfig.Attribute{
 			{
 				Key:   "should_exclude",
@@ -131,7 +131,7 @@ func TestLoadingConfigStrictLogs(t *testing.T) {
 				ErrorMode: ottl.PropagateError,
 				Logs: LogFilters{
 					Include: &LogMatchProperties{
-						LogMatchType: Strict,
+						LogMatchType: strictType,
 					},
 				},
 			},
@@ -182,12 +182,12 @@ func TestLoadingConfigStrictLogs(t *testing.T) {
 func TestLoadingConfigSeverityLogsStrict(t *testing.T) {
 
 	testDataLogPropertiesInclude := &LogMatchProperties{
-		LogMatchType:  Strict,
+		LogMatchType:  strictType,
 		SeverityTexts: []string{"INFO"},
 	}
 
 	testDataLogPropertiesExclude := &LogMatchProperties{
-		LogMatchType:  Strict,
+		LogMatchType:  strictType,
 		SeverityTexts: []string{"DEBUG", "DEBUG2", "DEBUG3", "DEBUG4"},
 	}
 
@@ -244,12 +244,12 @@ func TestLoadingConfigSeverityLogsStrict(t *testing.T) {
 // TestLoadingConfigSeverityLogsRegexp tests loading testdata/config_logs_severity_regexp.yaml
 func TestLoadingConfigSeverityLogsRegexp(t *testing.T) {
 	testDataLogPropertiesInclude := &LogMatchProperties{
-		LogMatchType:  Regexp,
+		LogMatchType:  regexpType,
 		SeverityTexts: []string{"INFO[2-4]?"},
 	}
 
 	testDataLogPropertiesExclude := &LogMatchProperties{
-		LogMatchType:  Regexp,
+		LogMatchType:  regexpType,
 		SeverityTexts: []string{"DEBUG[2-4]?"},
 	}
 
@@ -307,12 +307,12 @@ func TestLoadingConfigSeverityLogsRegexp(t *testing.T) {
 func TestLoadingConfigBodyLogsStrict(t *testing.T) {
 
 	testDataLogPropertiesInclude := &LogMatchProperties{
-		LogMatchType: Strict,
+		LogMatchType: strictType,
 		LogBodies:    []string{"This is an important event"},
 	}
 
 	testDataLogPropertiesExclude := &LogMatchProperties{
-		LogMatchType: Strict,
+		LogMatchType: strictType,
 		LogBodies:    []string{"This event is not important"},
 	}
 
@@ -370,12 +370,12 @@ func TestLoadingConfigBodyLogsStrict(t *testing.T) {
 func TestLoadingConfigBodyLogsRegexp(t *testing.T) {
 
 	testDataLogPropertiesInclude := &LogMatchProperties{
-		LogMatchType: Regexp,
+		LogMatchType: regexpType,
 		LogBodies:    []string{"^IMPORTANT:"},
 	}
 
 	testDataLogPropertiesExclude := &LogMatchProperties{
-		LogMatchType: Regexp,
+		LogMatchType: regexpType,
 		LogBodies:    []string{"^MINOR:"},
 	}