Skip to content

Commit 3e072d2

Browse files
[chore] refactor(sumologicexporter): use confighttp.NewDefaultClientConfig (#31510)
Use `confighttp.NewDefaultClientConfig` instead of `confighttp.ClientConfig{...}`. **Link to tracking Issue:** #6641 **Testing:** Unit tests
1 parent 916a2fe commit 3e072d2

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

exporter/sumologicexporter/config.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ type Config struct {
6262

6363
// createDefaultClientConfig returns default http client settings
6464
func createDefaultClientConfig() confighttp.ClientConfig {
65-
return confighttp.ClientConfig{
66-
Timeout: defaultTimeout,
67-
}
65+
config := confighttp.NewDefaultClientConfig()
66+
config.Timeout = defaultTimeout
67+
return config
6868
}
6969

7070
// LogFormatType represents log_format

exporter/sumologicexporter/factory_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ func TestCreateDefaultConfig(t *testing.T) {
4040
GraphiteTemplate: "%{_metric_}",
4141

4242
ClientConfig: confighttp.ClientConfig{
43-
Timeout: 5 * time.Second,
43+
IdleConnTimeout: confighttp.NewDefaultClientConfig().IdleConnTimeout,
44+
MaxIdleConns: confighttp.NewDefaultClientConfig().MaxIdleConns,
45+
Timeout: 5 * time.Second,
4446
},
4547
BackOffConfig: configretry.NewDefaultBackOffConfig(),
4648
QueueSettings: qs,

0 commit comments

Comments
 (0)