We should probably at least check the error value and log it...

sfc-gh-kstewart · sfc-gh-kstewart · commit 357fd7c41a27 · 2024-08-21T16:58:01.000-07:00
diff --git a/pkg/stanza/fileconsumer/internal/reader/reader_unix.go b/pkg/stanza/fileconsumer/internal/reader/reader_unix.go
@@ -24,5 +24,7 @@ func (r *Reader) tryLockFile() bool {
 }
 
 func (r *Reader) unlockFile() {
-	unix.Flock(int(r.file.Fd()), unix.LOCK_UN)
+	if err := unix.Flock(int(r.file.Fd()), unix.LOCK_UN); err != nil {
+		r.set.Logger.Error("Failed to unlock", zap.Error(err))
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -24,5 +24,7 @@ func (r *Reader) tryLockFile() bool {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`func (r *Reader) unlockFile() {`
`27`		`- unix.Flock(int(r.file.Fd()), unix.LOCK_UN)`
	`27`	`+ if err := unix.Flock(int(r.file.Fd()), unix.LOCK_UN); err != nil {`
	`28`	`+ r.set.Logger.Error("Failed to unlock", zap.Error(err))`
	`29`	`+ }`
`28`	`30`	`}`