Skip to content

Commit 3557f26

Browse files
authored
[k8sobjectsreceiver] fix receiver fails when some unrelated API is down (#29707)
**Description:** <Describe what has changed.> This change allows passing validation even some of K8S APIs is down, we will look thru the groups and resources for the ones available. <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** <Issue number if applicable> #29706 **Testing:** <Describe what testing was performed and which tests were added.> - manually in a kind cluster with metrics-server being down. **Documentation:** <Describe the documentation added.>
1 parent 6d2b009 commit 3557f26

File tree

2 files changed

+32
-1
lines changed

2 files changed

+32
-1
lines changed

.chloggen/k8sobject-crash.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: k8sobjectsreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: "fix k8sobjects receiver fails when some unrelated Kubernetes API is down"
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [29706]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [user]

receiver/k8sobjectsreceiver/config.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,11 @@ func (c *Config) getValidObjects() (map[string][]*schema.GroupVersionResource, e
128128

129129
res, err := dc.ServerPreferredResources()
130130
if err != nil {
131-
return nil, err
131+
// Check if Partial result is returned from discovery client, that means some API servers have issues,
132+
// but we can still continue, as we check for the needed groups later in Validate function.
133+
if res != nil && !discovery.IsGroupDiscoveryFailedError(err) {
134+
return nil, err
135+
}
132136
}
133137

134138
validObjects := make(map[string][]*schema.GroupVersionResource)

0 commit comments

Comments
 (0)