Skip to content

Commit 3514800

Browse files
VihasMakwanaVihas Splunk
authored andcommitted
Merge branch 'main' into kafka-header-extract
2 parents 8c81cfe + ccfd8b1 commit 3514800

File tree

14 files changed

+247
-107
lines changed

14 files changed

+247
-107
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: dynatraceexporter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Rename struct to keep expected `exporter.Factory` and pass checkapi.
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [26304]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [api]
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: pkg/stanza
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Add 'overwrite_text' option to severity parser.
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [26671]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext: |
19+
Allows the user to overwrite the text of the severity parser with the official string representation of the severity level.
20+
21+
# If your change doesn't affect end users or the exported elements of any package,
22+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
23+
# Optional: The change log or logs in which this entry should be included.
24+
# e.g. '[user]' or '[user, api]'
25+
# Include 'user' if the change is relevant to end users.
26+
# Include 'api' if there is a change to a library API.
27+
# Default: '[user]'
28+
change_logs: []

cmd/checkapi/allowlist.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
connector/servicegraphconnector
22
exporter/coralogixexporter
3-
exporter/dynatraceexporter
43
exporter/kafkaexporter
54
exporter/pulsarexporter
65
extension/observer/ecsobserver

exporter/dynatraceexporter/factory.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88

99
"go.opentelemetry.io/collector/component"
1010
"go.opentelemetry.io/collector/config/confighttp"
11-
exp "go.opentelemetry.io/collector/exporter"
11+
"go.opentelemetry.io/collector/exporter"
1212
"go.opentelemetry.io/collector/exporter/exporterhelper"
1313

1414
dtconfig "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/dynatraceexporter/config"
@@ -17,11 +17,11 @@ import (
1717
)
1818

1919
// NewFactory creates a Dynatrace exporter factory
20-
func NewFactory() exp.Factory {
21-
return exp.NewFactory(
20+
func NewFactory() exporter.Factory {
21+
return exporter.NewFactory(
2222
metadata.Type,
2323
createDefaultConfig,
24-
exp.WithMetrics(createMetricsExporter, metadata.MetricsStability),
24+
exporter.WithMetrics(createMetricsExporter, metadata.MetricsStability),
2525
)
2626
}
2727

@@ -45,9 +45,9 @@ func createDefaultConfig() component.Config {
4545
// createMetricsExporter creates a metrics exporter based on this
4646
func createMetricsExporter(
4747
ctx context.Context,
48-
set exp.CreateSettings,
48+
set exporter.CreateSettings,
4949
c component.Config,
50-
) (exp.Metrics, error) {
50+
) (exporter.Metrics, error) {
5151

5252
cfg := c.(*dtconfig.Config)
5353

exporter/dynatraceexporter/metrics_exporter.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717
"github.com/dynatrace-oss/dynatrace-metric-utils-go/metric/dimensions"
1818
"go.opentelemetry.io/collector/component"
1919
"go.opentelemetry.io/collector/consumer/consumererror"
20-
exp "go.opentelemetry.io/collector/exporter"
20+
"go.opentelemetry.io/collector/exporter"
2121
"go.opentelemetry.io/collector/pdata/pmetric"
2222
"go.uber.org/zap"
2323

@@ -31,8 +31,8 @@ const (
3131
cMaxAgeSeconds = 900
3232
)
3333

34-
// NewExporter exports to a Dynatrace Metrics v2 API
35-
func newMetricsExporter(params exp.CreateSettings, cfg *config.Config) *exporter {
34+
// newMetricsExporter exports to a Dynatrace Metrics v2 API
35+
func newMetricsExporter(params exporter.CreateSettings, cfg *config.Config) *metricsExporter {
3636
var confDefaultDims []dimensions.Dimension
3737
for key, value := range cfg.DefaultDimensions {
3838
confDefaultDims = append(confDefaultDims, dimensions.NewDimension(key, value))
@@ -48,7 +48,7 @@ func newMetricsExporter(params exp.CreateSettings, cfg *config.Config) *exporter
4848
prevPts := ttlmap.New(cSweepIntervalSeconds, cMaxAgeSeconds)
4949
prevPts.Start()
5050

51-
return &exporter{
51+
return &metricsExporter{
5252
settings: params.TelemetrySettings,
5353
cfg: cfg,
5454
defaultDimensions: defaultDimensions,
@@ -57,8 +57,8 @@ func newMetricsExporter(params exp.CreateSettings, cfg *config.Config) *exporter
5757
}
5858
}
5959

60-
// exporter forwards metrics to a Dynatrace agent
61-
type exporter struct {
60+
// metricsExporter forwards metrics to a Dynatrace agent
61+
type metricsExporter struct {
6262
settings component.TelemetrySettings
6363
cfg *config.Config
6464
client *http.Client
@@ -82,7 +82,7 @@ func dimensionsFromTags(tags []string) dimensions.NormalizedDimensionList {
8282
return dimensions.NewNormalizedDimensionList(dims...)
8383
}
8484

85-
func (e *exporter) PushMetricsData(ctx context.Context, md pmetric.Metrics) error {
85+
func (e *metricsExporter) PushMetricsData(ctx context.Context, md pmetric.Metrics) error {
8686
if e.isDisabled {
8787
return nil
8888
}
@@ -109,7 +109,7 @@ func (e *exporter) PushMetricsData(ctx context.Context, md pmetric.Metrics) erro
109109
return nil
110110
}
111111

112-
func (e *exporter) serializeMetrics(md pmetric.Metrics) []string {
112+
func (e *metricsExporter) serializeMetrics(md pmetric.Metrics) []string {
113113
var lines []string
114114

115115
resourceMetrics := md.ResourceMetrics()
@@ -154,7 +154,7 @@ var lastLog int64
154154

155155
// send sends a serialized metric batch to Dynatrace.
156156
// An error indicates all lines were dropped regardless of the returned number.
157-
func (e *exporter) send(ctx context.Context, lines []string) error {
157+
func (e *metricsExporter) send(ctx context.Context, lines []string) error {
158158
e.settings.Logger.Debug("Exporting", zap.Int("lines", len(lines)))
159159

160160
if now := time.Now().Unix(); len(lines) > apiconstants.GetPayloadLinesLimit() && now-lastLog > 60 {
@@ -185,7 +185,7 @@ func (e *exporter) send(ctx context.Context, lines []string) error {
185185

186186
// send sends a serialized metric batch to Dynatrace.
187187
// An error indicates all lines were dropped regardless of the returned number.
188-
func (e *exporter) sendBatch(ctx context.Context, lines []string) error {
188+
func (e *metricsExporter) sendBatch(ctx context.Context, lines []string) error {
189189
message := strings.Join(lines, "\n")
190190
e.settings.Logger.Debug(
191191
"sending a batch of metric lines",
@@ -278,7 +278,7 @@ func (e *exporter) sendBatch(ctx context.Context, lines []string) error {
278278
}
279279

280280
// start starts the exporter
281-
func (e *exporter) start(_ context.Context, host component.Host) (err error) {
281+
func (e *metricsExporter) start(_ context.Context, host component.Host) (err error) {
282282
client, err := e.cfg.HTTPClientSettings.ToClient(host, e.settings)
283283
if err != nil {
284284
e.settings.Logger.Error("Failed to construct HTTP client", zap.Error(err))
@@ -290,7 +290,7 @@ func (e *exporter) start(_ context.Context, host component.Host) (err error) {
290290
return nil
291291
}
292292

293-
func (e *exporter) unmarshalResponseBody(resp *http.Response) (metricsResponse, error) {
293+
func (e *metricsExporter) unmarshalResponseBody(resp *http.Response) (metricsResponse, error) {
294294
bodyBytes, err := io.ReadAll(resp.Body)
295295
responseBody := metricsResponse{}
296296
if err != nil {

exporter/dynatraceexporter/metrics_exporter_test.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ func Test_exporter_PushMetricsData(t *testing.T) {
159159
}
160160

161161
t.Run(test.name, func(t *testing.T) {
162-
e := &exporter{
162+
e := &metricsExporter{
163163
settings: test.fields.settings,
164164
cfg: test.fields.cfg,
165165
client: test.fields.client,
@@ -305,7 +305,7 @@ func Test_SumMetrics(t *testing.T) {
305305
prevPts := ttlmap.New(cSweepIntervalSeconds, cMaxAgeSeconds)
306306

307307
// set up the exporter
308-
exp := &exporter{
308+
exp := &metricsExporter{
309309
settings: componenttest.NewNopTelemetrySettings(),
310310
cfg: &config.Config{
311311
APIToken: "token",
@@ -368,7 +368,7 @@ func Test_exporter_PushMetricsData_EmptyPayload(t *testing.T) {
368368
noneMetric := metrics.AppendEmpty()
369369
noneMetric.SetName("none")
370370

371-
e := &exporter{
371+
e := &metricsExporter{
372372
settings: componenttest.NewNopTelemetrySettings(),
373373
cfg: &config.Config{
374374
HTTPClientSettings: confighttp.HTTPClientSettings{Endpoint: ts.URL},
@@ -405,7 +405,7 @@ func Test_exporter_PushMetricsData_isDisabled(t *testing.T) {
405405
intGaugeDataPoint.SetIntValue(10)
406406
intGaugeDataPoint.SetTimestamp(testTimestamp)
407407

408-
e := &exporter{
408+
e := &metricsExporter{
409409
settings: componenttest.NewNopTelemetrySettings(),
410410
cfg: &config.Config{
411411
HTTPClientSettings: confighttp.HTTPClientSettings{Endpoint: ts.URL},
@@ -431,7 +431,7 @@ func Test_exporter_send_BadRequest(t *testing.T) {
431431
}))
432432
defer ts.Close()
433433

434-
e := &exporter{
434+
e := &metricsExporter{
435435
settings: componenttest.NewNopTelemetrySettings(),
436436
cfg: &config.Config{
437437
HTTPClientSettings: confighttp.HTTPClientSettings{Endpoint: ts.URL},
@@ -456,7 +456,7 @@ func Test_exporter_send_Unauthorized(t *testing.T) {
456456
}))
457457
defer ts.Close()
458458

459-
e := &exporter{
459+
e := &metricsExporter{
460460
settings: componenttest.NewNopTelemetrySettings(),
461461
cfg: &config.Config{
462462
HTTPClientSettings: confighttp.HTTPClientSettings{Endpoint: ts.URL},
@@ -481,7 +481,7 @@ func Test_exporter_send_TooLarge(t *testing.T) {
481481
}))
482482
defer ts.Close()
483483

484-
e := &exporter{
484+
e := &metricsExporter{
485485
settings: componenttest.NewNopTelemetrySettings(),
486486
cfg: &config.Config{
487487
HTTPClientSettings: confighttp.HTTPClientSettings{Endpoint: ts.URL},
@@ -506,7 +506,7 @@ func Test_exporter_send_NotFound(t *testing.T) {
506506
}))
507507
defer ts.Close()
508508

509-
e := &exporter{
509+
e := &metricsExporter{
510510
settings: componenttest.NewNopTelemetrySettings(),
511511
cfg: &config.Config{
512512
APIToken: "token",
@@ -534,7 +534,7 @@ func Test_exporter_send_TooManyRequests(t *testing.T) {
534534
}))
535535
defer ts.Close()
536536

537-
e := &exporter{
537+
e := &metricsExporter{
538538
settings: componenttest.NewNopTelemetrySettings(),
539539
cfg: &config.Config{
540540
APIToken: "token",
@@ -557,7 +557,7 @@ func Test_exporter_send_MiscellaneousErrorCode(t *testing.T) {
557557
}))
558558
defer ts.Close()
559559

560-
e := &exporter{
560+
e := &metricsExporter{
561561
settings: componenttest.NewNopTelemetrySettings(),
562562
cfg: &config.Config{
563563
APIToken: "token",
@@ -588,7 +588,7 @@ func Test_exporter_send_chunking(t *testing.T) {
588588
}))
589589
defer ts.Close()
590590

591-
e := &exporter{
591+
e := &metricsExporter{
592592
settings: componenttest.NewNopTelemetrySettings(),
593593
cfg: &config.Config{
594594
HTTPClientSettings: confighttp.HTTPClientSettings{Endpoint: ts.URL},
@@ -672,7 +672,7 @@ func Test_exporter_PushMetricsData_Error(t *testing.T) {
672672
}
673673

674674
t.Run(test.name, func(t *testing.T) {
675-
e := &exporter{
675+
e := &metricsExporter{
676676
settings: componenttest.NewNopTelemetrySettings(),
677677
cfg: test.fields.cfg,
678678
client: test.fields.client,

pkg/stanza/entry/severity.go

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -52,31 +52,31 @@ const (
5252
)
5353

5454
var sevText = map[Severity]string{
55-
Default: "default",
56-
Trace: "trace",
57-
Trace2: "trace2",
58-
Trace3: "trace3",
59-
Trace4: "trace4",
60-
Debug: "debug",
61-
Debug2: "debug2",
62-
Debug3: "debug3",
63-
Debug4: "debug4",
64-
Info: "info",
65-
Info2: "info2",
66-
Info3: "info3",
67-
Info4: "info4",
68-
Warn: "warn",
69-
Warn2: "warn2",
70-
Warn3: "warn3",
71-
Warn4: "warn4",
72-
Error: "error",
73-
Error2: "error2",
74-
Error3: "error3",
75-
Error4: "error4",
76-
Fatal: "fatal",
77-
Fatal2: "fatal2",
78-
Fatal3: "fatal3",
79-
Fatal4: "fatal4",
55+
Default: "DEFAULT",
56+
Trace: "TRACE",
57+
Trace2: "TRACE2",
58+
Trace3: "TRACE3",
59+
Trace4: "TRACE4",
60+
Debug: "DEBUG",
61+
Debug2: "DEBUG2",
62+
Debug3: "DEBUG3",
63+
Debug4: "DEBUG4",
64+
Info: "INFO",
65+
Info2: "INFO2",
66+
Info3: "INFO3",
67+
Info4: "INFO4",
68+
Warn: "WARN",
69+
Warn2: "WARN2",
70+
Warn3: "WARN3",
71+
Warn4: "WARN4",
72+
Error: "ERROR",
73+
Error2: "ERROR2",
74+
Error3: "ERROR3",
75+
Error4: "ERROR4",
76+
Fatal: "FATAL",
77+
Fatal2: "FATAL2",
78+
Fatal3: "FATAL3",
79+
Fatal4: "FATAL4",
8080
}
8181

8282
// ToString converts a severity to a string

0 commit comments

Comments
 (0)