Skip to content

Commit 3449903

Browse files
authored
[receiver/vcenter] Adds New Packet Dropped Rate Metric for VMs (#32930)
**Description:** <Describe what has changed.> Adds new default disabled (with Warning log for default enabled on next release) metric `vcenter.vm.network.packet.drop.rate` for Virtual Machines. This metric makes use of the `droppedRx` and `droppedTx` Network performance metrics detailed [here](https://vdc-repo.vmware.com/vmwb-repository/dcr-public/d1902b0e-d479-46bf-8ac9-cee0e31e8ec0/07ce8dbd-db48-4261-9b8f-c6d3ad8ba472/network_counters.html) for Virtual machines. This would use the same metric attributes as the other VM packet metrics and closely match `vcenter.vm.network.packet.rate` in every other way. **Link to tracking Issue:** <Issue number if applicable> #32929 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata.
1 parent 89d09e0 commit 3449903

13 files changed

+788
-0
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: vcenterreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: "Adds inititially disabled packet drop rate metric for VMs."
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [32929]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [user]

receiver/vcenterreceiver/documentation.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -508,6 +508,23 @@ The memory utilization of the VM.
508508
| ---- | ----------- | ---------- |
509509
| % | Gauge | Double |
510510
511+
### vcenter.vm.network.packet.drop.rate
512+
513+
The rate of transmitted or received packets dropped by each vNIC (virtual network interface controller) on the virtual machine.
514+
515+
As measured over the most recent 20s interval.
516+
517+
| Unit | Metric Type | Value Type |
518+
| ---- | ----------- | ---------- |
519+
| {packets/sec} | Gauge | Double |
520+
521+
#### Attributes
522+
523+
| Name | Description | Values |
524+
| ---- | ----------- | ------ |
525+
| direction | The direction of network throughput. | Str: ``transmitted``, ``received`` |
526+
| object | The object on the virtual machine or host that is being reported on. | Any Str |
527+
511528
### vcenter.vm.network.packet.rate
512529
513530
The rate of packets transmitted or received by each vNIC (virtual network interface controller) on the virtual machine.

receiver/vcenterreceiver/internal/metadata/generated_config.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/vcenterreceiver/internal/metadata/generated_config_test.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/vcenterreceiver/internal/metadata/generated_metrics.go

Lines changed: 63 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/vcenterreceiver/internal/metadata/generated_metrics_test.go

Lines changed: 25 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/vcenterreceiver/internal/metadata/testdata/config.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ all_set:
8181
enabled: true
8282
vcenter.vm.network.packet.count:
8383
enabled: true
84+
vcenter.vm.network.packet.drop.rate:
85+
enabled: true
8486
vcenter.vm.network.packet.rate:
8587
enabled: true
8688
vcenter.vm.network.throughput:
@@ -194,6 +196,8 @@ none_set:
194196
enabled: false
195197
vcenter.vm.network.packet.count:
196198
enabled: false
199+
vcenter.vm.network.packet.drop.rate:
200+
enabled: false
197201
vcenter.vm.network.packet.rate:
198202
enabled: false
199203
vcenter.vm.network.throughput:

0 commit comments

Comments
 (0)