Skip to content

Commit 270c86c

Browse files
crobert-1atoulme
andauthored
[receiver/sqlserver] Remove warning on resource attributes (#38831)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The `server.address` and `server.port` resource attributes in the SQL Server receiver had warnings that they will be enabled by default in a future release. These resource attributes are being set by simply passing through config option values. The config options, `server` and `port`, are optional. Also, the SQL Server receiver supports scraping Windows Performance counters for metrics, which render these resource attributes meaningless. For these reasons, the resource attributes should continue to be disabled by default. There may be some way to get these resource attributes from windows perf counters, but that is a separate work item that would be required before enabling. If that work gets done at some point we can revisit enabling these by default. Related: #35183 --------- Co-authored-by: Antoine Toulme <[email protected]>
1 parent 729713d commit 270c86c

File tree

4 files changed

+31
-18
lines changed

4 files changed

+31
-18
lines changed
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: receiver/sqlserver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Remove warning that `server.address` and `server.port` resource attributes will be enabled
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [38831]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext: |
19+
There is no intention of enabling these resource attributes by default,
20+
this change is to simply remove the warning.
21+
The `server.address` and `server.port` resource attributes were, and still are,
22+
disabled by default.
23+
24+
# If your change doesn't affect end users or the exported elements of any package,
25+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
26+
# Optional: The change log or logs in which this entry should be included.
27+
# e.g. '[user]' or '[user, api]'
28+
# Include 'user' if the change is relevant to end users.
29+
# Include 'api' if there is a change to a library API.
30+
# Default: '[user]'
31+
change_logs: []

receiver/sqlserverreceiver/internal/metadata/generated_metrics.go

Lines changed: 0 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/sqlserverreceiver/internal/metadata/generated_metrics_test.go

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/sqlserverreceiver/metadata.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,10 @@ resource_attributes:
2727
description: Name of the database host.
2828
enabled: false
2929
type: string
30-
warnings:
31-
if_enabled_not_set: "This attribute will be enabled by default starting in release v0.121.0."
3230
server.port:
3331
description: Server port number.
3432
enabled: false
3533
type: int
36-
warnings:
37-
if_enabled_not_set: "This attribute will be enabled by default starting in release v0.121.0."
3834

3935
attributes:
4036
page.operations:

0 commit comments

Comments
 (0)