Skip to content

Commit 254818a

Browse files
committed
[processor/k8sattributes] Move "k8sattr.rfc3339" feature gate to Beta
Time format of `k8s.pod.start_time` attribute value migrated from RFC3339: Before: 2023-07-10 12:34:39.740638 -0700 PDT m=+0.020184946 After: 2023-07-10T12:39:53.112485-07:00 The feature gate can be temporary reverted back by adding `--feature-gate=-k8sattr.rfc3339` to the command line.
1 parent 49438fe commit 254818a

File tree

3 files changed

+33
-8
lines changed

3 files changed

+33
-8
lines changed
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: processor/k8sattributes
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Graduate "k8sattr.rfc3339" feature gate to Beta.
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [28817]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext: |
19+
Time format of `k8s.pod.start_time` attribute value migrated from RFC3339:
20+
Before: 2023-07-10 12:34:39.740638 -0700 PDT m=+0.020184946
21+
After: 2023-07-10T12:39:53.112485-07:00
22+
The feature gate can be temporary reverted back by adding `--feature-gate=-k8sattr.rfc3339` to the command line.
23+
24+
# If your change doesn't affect end users or the exported elements of any package,
25+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
26+
# Optional: The change log or logs in which this entry should be included.
27+
# e.g. '[user]' or '[user, api]'
28+
# Include 'user' if the change is relevant to end users.
29+
# Include 'api' if there is a change to a library API.
30+
# Default: '[user]'
31+
change_logs: [user]

processor/k8sattributesprocessor/internal/kube/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ import (
2626
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sattributesprocessor/internal/observability"
2727
)
2828

29-
// Upgrade to StageBeta in v0.83.0
29+
// Upgrade to StageStable in v0.92.0
3030
var enableRFC3339Timestamp = featuregate.GlobalRegistry().MustRegister(
3131
"k8sattr.rfc3339",
32-
featuregate.StageAlpha,
32+
featuregate.StageBeta,
3333
featuregate.WithRegisterDescription("When enabled, uses RFC3339 format for k8s.pod.start_time value"),
3434
featuregate.WithRegisterFromVersion("v0.82.0"),
3535
)

processor/k8sattributesprocessor/processor.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,6 @@ func (kp *kubernetesprocessor) initKubeClient(logger *zap.Logger, kubeClient kub
5050
}
5151

5252
func (kp *kubernetesprocessor) Start(_ context.Context, _ component.Host) error {
53-
if kp.rules.StartTime {
54-
kp.logger.Warn("k8s.pod.start_time value will be changed to use RFC3339 format in v0.83.0. " +
55-
"see https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/24016 for more information. " +
56-
"enable feature-gate k8sattr.rfc3339 to opt into this change.")
57-
}
58-
5953
if !kp.passthroughMode {
6054
go kp.kc.Start()
6155
}

0 commit comments

Comments
 (0)