Skip to content

Commit 20b3071

Browse files
dashpoledmitryax
andauthored
prometheusreceiver: remove unused buffer_period and buffer_count configuration options (#24257)
**Description:** Fixes #24258 Found while adding documentation for #24256. The prometheus receiver had two config options that AFAICT have never been used. The config options have existed since the very first commit ever for the Prometheus receiver: 7c728ef Co-authored-by: Dmitrii Anoshin <[email protected]>
1 parent 1c36f05 commit 20b3071

File tree

4 files changed

+20
-6
lines changed

4 files changed

+20
-6
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Use this changelog template to create an entry for release notes.
2+
# If your change doesn't affect end users, such as a test fix or a tooling change,
3+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
4+
5+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
6+
change_type: 'breaking'
7+
8+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
9+
component: prometheusreciever
10+
11+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
12+
note: Remove unused buffer_period and buffer_count configuration options
13+
14+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
15+
issues: [24258]
16+
17+
# (Optional) One or more lines of additional information to render under the primary note.
18+
# These lines will be padded with 2 spaces and then inserted directly into the document.
19+
# Use pipe (|) for multiline entries.
20+
subtext:

receiver/prometheusreceiver/config.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ const (
3434
type Config struct {
3535
PrometheusConfig *promconfig.Config `mapstructure:"-"`
3636
TrimMetricSuffixes bool `mapstructure:"trim_metric_suffixes"`
37-
BufferPeriod time.Duration `mapstructure:"buffer_period"`
38-
BufferCount int `mapstructure:"buffer_count"`
3937
// UseStartTimeMetric enables retrieving the start time of all counter metrics
4038
// from the process_start_time_seconds metric. This is only correct if all counters on that endpoint
4139
// started after the process start time, and the process is the only actor exporting the metric after

receiver/prometheusreceiver/testdata/config.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
prometheus:
22
prometheus/customname:
3-
buffer_period: 234
4-
buffer_count: 45
53
trim_metric_suffixes: true
64
use_start_time_metric: true
75
start_time_metric_regex: '^(.+_)*process_start_time_seconds$'

receiver/prometheusreceiver/testdata/invalid-config-prometheus-unsupported-features.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
prometheus:
2-
buffer_period: 234
3-
buffer_count: 45
42
use_start_time_metric: true
53
start_time_metric_regex: '^(.+_)*process_start_time_seconds$'
64
config:

0 commit comments

Comments
 (0)