Skip to content

Commit 1f4c9ab

Browse files
authored
Improve test coverage in k8s processor for metrics (#362)
It's the tests part missed to get 95% percent coverage in #358.
1 parent c72b1c5 commit 1f4c9ab

File tree

1 file changed

+32
-2
lines changed

1 file changed

+32
-2
lines changed

processor/k8sprocessor/processor_test.go

Lines changed: 32 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func TestNewTraceProcessor(t *testing.T) {
4545
require.NoError(t, err)
4646
}
4747

48-
func TestBadOption(t *testing.T) {
48+
func TestTraceProcessorBadOption(t *testing.T) {
4949
opt := func(p *kubernetesprocessor) error {
5050
return fmt.Errorf("bad option")
5151
}
@@ -60,7 +60,7 @@ func TestBadOption(t *testing.T) {
6060
assert.Equal(t, err.Error(), "bad option")
6161
}
6262

63-
func TestBadClientProvider(t *testing.T) {
63+
func TestTraceProcessorBadClientProvider(t *testing.T) {
6464
clientProvider := func(_ *zap.Logger, _ k8sconfig.APIConfig, _ kube.ExtractionRules, _ kube.Filters, _ kube.APIClientsetProvider, _ kube.InformerProvider) (kube.Client, error) {
6565
return nil, fmt.Errorf("bad client error")
6666
}
@@ -368,6 +368,36 @@ func TestNewMetricsProcessor(t *testing.T) {
368368
require.NoError(t, err)
369369
}
370370

371+
func TestMetricsProcessorBadOption(t *testing.T) {
372+
opt := func(p *kubernetesprocessor) error {
373+
return fmt.Errorf("bad option")
374+
}
375+
p, err := NewMetricsProcessor(
376+
zap.NewNop(),
377+
exportertest.NewNopMetricsExporter(),
378+
newFakeClient,
379+
opt,
380+
)
381+
assert.Nil(t, p)
382+
assert.Error(t, err)
383+
assert.Equal(t, err.Error(), "bad option")
384+
}
385+
386+
func TestMetricsProcessorBadClientProvider(t *testing.T) {
387+
clientProvider := func(_ *zap.Logger, _ k8sconfig.APIConfig, _ kube.ExtractionRules, _ kube.Filters, _ kube.APIClientsetProvider, _ kube.InformerProvider) (kube.Client, error) {
388+
return nil, fmt.Errorf("bad client error")
389+
}
390+
p, err := NewMetricsProcessor(
391+
zap.NewNop(),
392+
exportertest.NewNopMetricsExporter(),
393+
clientProvider,
394+
)
395+
396+
assert.Nil(t, p)
397+
assert.Error(t, err)
398+
assert.Equal(t, err.Error(), "bad client error")
399+
}
400+
371401
func TestMetricsProcessorNoAttrs(t *testing.T) {
372402
next := &testMetricsConsumer{}
373403
p, err := NewMetricsProcessor(

0 commit comments

Comments
 (0)