Skip to content

Commit 1e255c3

Browse files
ccressentatoulmecrobert-1
authored
Add additional physical read/write metrics to oracledb receiver (#37814)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds the following metrics to the `oracledb` receiver: - 'physical reads direct' (disabled by default) - 'physical read io requests' (disabled by default) - 'physical writes' (enabled by default) - 'physical writes direct' (disabled by default) - 'physical write io requests' (disabled by default) <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue N/A <!--Describe what testing was performed and which tests were added.--> #### Testing Manual testing. <!--Describe the documentation added.--> #### Documentation Automatically generated by `mdatagen` for each metric. --------- Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Curtis Robert <[email protected]>
1 parent bf2e9b0 commit 1e255c3

File tree

10 files changed

+754
-149
lines changed

10 files changed

+754
-149
lines changed
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: oracledbreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Add support for additional read/write metrics
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [37814]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext: |
19+
The following metrics are now available, all disabled by default:
20+
'physical reads direct', 'physical writes', 'physical writes direct',
21+
'physical read io requests' and 'physical write io requests' metrics'
22+
23+
# If your change doesn't affect end users or the exported elements of any package,
24+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
25+
# Optional: The change log or logs in which this entry should be included.
26+
# e.g. '[user]' or '[user, api]'
27+
# Include 'user' if the change is relevant to end users.
28+
# Include 'api' if there is a change to a library API.
29+
# Default: '[user]'
30+
change_logs: [user]

receiver/oracledbreceiver/documentation.md

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,46 @@ Number of times a current block was requested from the buffer cache.
257257
| ---- | ----------- | ---------- | ----------------------- | --------- |
258258
| {gets} | Sum | Int | Cumulative | true |
259259
260+
### oracledb.physical_read_io_requests
261+
262+
Number of read requests for application activity
263+
264+
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
265+
| ---- | ----------- | ---------- | ----------------------- | --------- |
266+
| {requests} | Sum | Int | Cumulative | true |
267+
268+
### oracledb.physical_reads_direct
269+
270+
Number of reads directly from disk, bypassing the buffer cache
271+
272+
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
273+
| ---- | ----------- | ---------- | ----------------------- | --------- |
274+
| {reads} | Sum | Int | Cumulative | true |
275+
276+
### oracledb.physical_write_io_requests
277+
278+
Number of write requests for application activity
279+
280+
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
281+
| ---- | ----------- | ---------- | ----------------------- | --------- |
282+
| {requests} | Sum | Int | Cumulative | true |
283+
284+
### oracledb.physical_writes
285+
286+
Number of physical writes
287+
288+
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
289+
| ---- | ----------- | ---------- | ----------------------- | --------- |
290+
| {writes} | Sum | Int | Cumulative | true |
291+
292+
### oracledb.physical_writes_direct
293+
294+
Number of writes directly to disk, bypassing the buffer cache
295+
296+
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
297+
| ---- | ----------- | ---------- | ----------------------- | --------- |
298+
| {writes} | Sum | Int | Cumulative | true |
299+
260300
## Resource Attributes
261301
262302
| Name | Description | Values | Enabled |

receiver/oracledbreceiver/internal/metadata/generated_config.go

Lines changed: 47 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_config_test.go

Lines changed: 64 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)