Skip to content

Commit 19c17a2

Browse files
Merge branch 'main' into add-splunk-rolling-restart-metric
2 parents e55ac47 + e0646e1 commit 19c17a2

File tree

4 files changed

+31
-3
lines changed

4 files changed

+31
-3
lines changed

.chloggen/move_ack_to_internal.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: fluentforwardreceiver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Unexport AckResponse
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [39831]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [api]

receiver/fluentforwardreceiver/ack.go renamed to receiver/fluentforwardreceiver/internal/ack.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
package fluentforwardreceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/fluentforwardreceiver"
4+
package internal // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/fluentforwardreceiver/internal"
55

66
import "github.com/tinylib/msgp/msgp"
77

receiver/fluentforwardreceiver/ack_test.go renamed to receiver/fluentforwardreceiver/internal/ack_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
package fluentforwardreceiver
4+
package internal
55

66
import (
77
"bytes"

receiver/fluentforwardreceiver/server.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
"github.com/tinylib/msgp/msgp"
1616
"go.uber.org/zap"
1717

18+
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/fluentforwardreceiver/internal"
1819
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/fluentforwardreceiver/internal/metadata"
1920
)
2021

@@ -125,7 +126,7 @@ func (s *server) handleConn(ctx context.Context, conn net.Conn) error {
125126
// messages -- this is the only thing that sends data back to the
126127
// client.
127128
if event.Chunk() != "" {
128-
err := msgp.Encode(conn, AckResponse{Ack: event.Chunk()})
129+
err := msgp.Encode(conn, internal.AckResponse{Ack: event.Chunk()})
129130
if err != nil {
130131
return fmt.Errorf("failed to acknowledge chunk %s: %w", event.Chunk(), err)
131132
}

0 commit comments

Comments
 (0)