[signalfxexporter] avoid stringify every data point that does not match the filter

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

.chloggen/improveperf.yaml

@@ -0,0 +1,11 @@
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: signalfxexporter
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Avoid stringify every data point that does not match the filter.
+
+# One or more tracking issues related to the change
+issues: [18274]

exporter/signalfxexporter/dpclient.go

@@ -95,7 +95,7 @@ func (s *sfxDPClient) pushMetricsData(
 	sfxDataPoints := s.converter.MetricsToSignalFxV2(md)
 	if s.logDataPoints {
 		for _, dp := range sfxDataPoints {
-			s.logger.Debug("Dispatching SFx datapoint", zap.String("dp", translation.DatapointToString(dp)))
+			s.logger.Debug("Dispatching SFx datapoint", zap.Stringer("dp", dp))
 		}
 	}
 	return s.pushMetricsDataForToken(ctx, sfxDataPoints, metricToken)

exporter/signalfxexporter/internal/translation/converter.go

@@ -16,7 +16,6 @@ package translation // import "github.com/open-telemetry/opentelemetry-collector
 
 import (
 	"fmt"
-	"strconv"
 	"strings"
 	"time"
 	"unicode"
@@ -114,7 +113,7 @@ func (c *MetricsConverter) translateAndFilter(dps []*sfxpb.DataPoint) []*sfxpb.D
 			}
 			resultSliceLen++
 		} else {
-			c.logger.Debug("Datapoint does not match filter, skipping", zap.String("dp", DatapointToString(dp)))
+			c.logger.Debug("Datapoint does not match filter, skipping", zap.Stringer("dp", dp))
 		}
 	}
 	dps = dps[:resultSliceLen]
@@ -251,7 +250,7 @@ func (dpv *datapointValidator) isValidNumberOfDimension(dp *sfxpb.DataPoint) boo
 	if len(dp.Dimensions) > maxNumberOfDimensions {
 		dpv.logger.Debug("dropping datapoint",
 			zap.String("reason", invalidNumberOfDimensions),
-			zap.String("datapoint", DatapointToString(dp)),
+			zap.Stringer("datapoint", dp),
 			zap.Int("number_of_dimensions", len(dp.Dimensions)),
 		)
 		return false
@@ -307,32 +306,3 @@ func CreateSampledLogger(logger *zap.Logger) *zap.Logger {
 	})
 	return logger.WithOptions(opts)
 }
-
-func DatapointToString(dp *sfxpb.DataPoint) string {
-	var tsStr string
-	if dp.Timestamp != 0 {
-		tsStr = strconv.FormatInt(dp.Timestamp, 10)
-	}
-
-	var dimsStr string
-	for _, dim := range dp.Dimensions {
-		dimsStr += dim.String()
-	}
-
-	return fmt.Sprintf("%s: %s (%s) %s\n%s", dp.Metric, dp.Value.String(), dpTypeToString(*dp.MetricType), tsStr, dimsStr)
-}
-
-func dpTypeToString(t sfxpb.MetricType) string {
-	switch t {
-	case sfxpb.MetricType_GAUGE:
-		return "Gauge"
-	case sfxpb.MetricType_COUNTER:
-		return "Counter"
-	case sfxpb.MetricType_ENUM:
-		return "Enum"
-	case sfxpb.MetricType_CUMULATIVE_COUNTER:
-		return "Cumulative Counter"
-	default:
-		return fmt.Sprintf("unsupported type %d", t)
-	}
-}

exporter/signalfxexporter/internal/translation/converter_test.go

@@ -769,7 +769,7 @@ func TestInvalidNumberOfDimensions(t *testing.T) {
 	assert.Equal(t, "dropping datapoint", observedLogs.All()[0].Message)
 	assert.ElementsMatch(t, []zap.Field{
 		{Type: zapcore.StringType, Key: "reason", String: invalidNumberOfDimensions},
-		{Type: zapcore.StringType, Key: "datapoint", String: DatapointToString(dpSFX)},
+		{Type: zapcore.StringerType, Key: "datapoint", Interface: dpSFX},
 		{Type: zapcore.Int64Type, Key: "number_of_dimensions", Integer: 37},
 	}, observedLogs.All()[0].Context)
 }