Skip to content

Switch from branch protection rules to rulesets #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trask opened this issue May 21, 2025 · 0 comments
Open

Switch from branch protection rules to rulesets #2769

trask opened this issue May 21, 2025 · 0 comments

Comments

@trask
Copy link
Member

trask commented May 21, 2025

Opening this for documentation purposes mainly.

Branch protection rules are being replace (for good reasons) by rulesets.

Unfortunately, there's an important feature (in OpenTelemetry repos at least) which is not available yet in rulesets: https://github.com/orgs/community/discussions/61107#discussioncomment-6569780.

I've experimented with moving to rulesets but keeping branch protection rules just for that one feature, and it kind of works, but then merge queues also need to be managed in the branch protection rule (instead of the ruleset), since otherwise GitHub will block the merge queue from merging to main. Basically, things get complicated and confusing, and I don't think it's worth it. Instead, I'd recommend we stay on classic branch protection rules for our core branch rules until the above feature is available 🤞.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant