Skip to content

Amalgamated source is not compiling #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsrinivas opened this issue Jul 13, 2014 · 2 comments
Closed

Amalgamated source is not compiling #13

zsrinivas opened this issue Jul 13, 2014 · 2 comments

Comments

@zsrinivas
Copy link
Contributor

I tried to comment out some of the missing #include 's from the amalgamated source so that my whole project compiles (which #include the amalgamted library).
But i'm in doubt that i may lose some features. How do i solve this problem ?

These are few screenshots of lines that i commented out.
screenshot from 2014-07-13 18 03 51
screenshot from 2014-07-13 18 06 35
screenshot from 2014-07-13 18 07 10
screenshot from 2014-07-13 18 08 32

@cdunn2001
Copy link
Contributor

Dup:
#12

If you submit a fix, I'll merge it immediately. Otherwise, I'll work on it later tonight.

@zsrinivas
Copy link
Contributor Author

actually it is not a duplicate,( i fixed it in #14 ) and I'm grateful for the chance to contribute.
and those lines shouldn't execute but they are! because JSON_IS_AMALGAMATION is not yet defined, i could have figured it long before but i have already installed jsoncpp locally(at the time of ./amalgamate.py) so i couldn't figure it out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants