Fix comments for exported funcs/vars/consts (#2938)

bogdandrutu · web-flow · commit d6a0f9ab760d · 2021-04-14T14:55:23.000-07:00
Signed-off-by: Bogdan Drutu &lt;bogdandrutu@gmail.com&gt;
diff --git a/component/componenttest/nop_exporter.go b/component/componenttest/nop_exporter.go
@@ -63,7 +63,7 @@ func (f *nopExporterFactory) CreateMetricsExporter(
 	return nopExporterInstance, nil
 }
 
-// CreateMetricsExporter implements component.ExporterFactory interface.
+// CreateLogsExporter implements component.ExporterFactory interface.
 func (f *nopExporterFactory) CreateLogsExporter(
 	_ context.Context,
 	_ component.ExporterCreateParams,
diff --git a/component/componenttest/nop_processor.go b/component/componenttest/nop_processor.go
@@ -68,7 +68,7 @@ func (f *nopProcessorFactory) CreateMetricsProcessor(
 	return nopProcessorInstance, nil
 }
 
-// CreateMetricsProcessor implements component.ProcessorFactory interface.
+// CreateLogsProcessor implements component.ProcessorFactory interface.
 func (f *nopProcessorFactory) CreateLogsProcessor(
 	_ context.Context,
 	_ component.ProcessorCreateParams,
diff --git a/component/componenttest/nop_receiver.go b/component/componenttest/nop_receiver.go
@@ -65,7 +65,7 @@ func (f *nopReceiverFactory) CreateMetricsReceiver(
 	return nopReceiverInstance, nil
 }
 
-// CreateMetricsReceiver implements component.ReceiverFactory interface.
+// CreateLogsReceiver implements component.ReceiverFactory interface.
 func (f *nopReceiverFactory) CreateLogsReceiver(
 	_ context.Context,
 	_ component.ReceiverCreateParams,
diff --git a/component/host.go b/component/host.go
@@ -38,13 +38,13 @@ type Host interface {
 	// other components that it creates.
 	GetFactory(kind Kind, componentType config.Type) Factory
 
-	// Return map of extensions. Only enabled and created extensions will be returned.
+	// GetExtensions returns the map of extensions. Only enabled and created extensions will be returned.
 	// Typically is used to find an extension by type or by full config name. Both cases
 	// can be done by iterating the returned map. There are typically very few extensions
 	// so there there is no performance implications due to iteration.
 	GetExtensions() map[config.NamedEntity]Extension
 
-	// Return map of exporters. Only enabled and created exporters will be returned.
+	// GetExporters returns the map of exporters. Only enabled and created exporters will be returned.
 	// Typically is used to find exporters by type or by full config name. Both cases
 	// can be done by iterating the returned map. There are typically very few exporters
 	// so there there is no performance implications due to iteration.
diff --git a/config/confighttp/confighttp.go b/config/confighttp/confighttp.go
@@ -95,7 +95,7 @@ type headerRoundTripper struct {
 	headers   map[string]string
 }
 
-// Custom RoundTrip that add headers
+// RoundTrip is a custom RoundTripper that adds headers to the request.
 func (interceptor *headerRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
 	for k, v := range interceptor.headers {
 		req.Header.Set(k, v)
diff --git a/exporter/prometheusexporter/collector.go b/exporter/prometheusexporter/collector.go
@@ -43,7 +43,7 @@ func newCollector(config *Config, logger *zap.Logger) *collector {
 	}
 }
 
-// Collector dynamically allocates metrics, describe shoud be noop
+// Describe is a no-op, because the collector dynamically allocates metrics.
 // https://github.com/prometheus/client_golang/blob/v1.9.0/prometheus/collector.go#L28-L40
 func (c *collector) Describe(_ chan<- *prometheus.Desc) {}
 
diff --git a/internal/goldendataset/pict_metrics_input_defs.go b/internal/goldendataset/pict_metrics_input_defs.go
@@ -51,15 +51,15 @@ const (
 	LabelsMany PICTNumPtLabels = "ManyLabels"
 )
 
-// Enumerates the number of points on each metric.
+// PICTNumPtsPerMetric enum for the number of points on each metric.
 type PICTNumPtsPerMetric string
 
 const (
 	NumPtsPerMetricOne  PICTNumPtsPerMetric = "OnePt"
 	NumPtsPerMetricMany PICTNumPtsPerMetric = "ManyPts"
 )
 
-// Enumerates the number of attributes on each resource.
+// PICTNumResourceAttrs enum for the number of attributes on each resource.
 type PICTNumResourceAttrs string
 
 const (
diff --git a/internal/goldendataset/pict_tracing_input_defs.go b/internal/goldendataset/pict_tracing_input_defs.go
@@ -23,7 +23,7 @@ const (
 	TracesColumnSpans                  = 2
 )
 
-// Enumerates the supported types of resource instances that can be generated.
+// PICTInputResource enum for the supported types of resource instances that can be generated.
 type PICTInputResource string
 
 const (
@@ -37,7 +37,7 @@ const (
 	ResourceExec      PICTInputResource = "Exec"
 )
 
-// Enumerates the number and kind of instrumentation library instances that can be generated.
+// PICTInputInstrumentationLibrary enum for the number and kind of instrumentation library instances that can be generated.
 type PICTInputInstrumentationLibrary string
 
 const (
@@ -46,7 +46,7 @@ const (
 	LibraryTwo  PICTInputInstrumentationLibrary = "Two"
 )
 
-// Enumerates the relative sizes of tracing spans that can be attached to an instrumentation library span instance.
+// PICTInputSpans enum for the relative sizes of tracing spans that can be attached to an instrumentation library span instance.
 type PICTInputSpans string
 
 const (
@@ -79,15 +79,15 @@ const (
 	SpansColumnStatus     = 6
 )
 
-// Enumerates the parent/child types of spans that can be generated.
+// PICTInputParent enum for the parent/child types of spans that can be generated.
 type PICTInputParent string
 
 const (
 	SpanParentRoot  PICTInputParent = "Root"
 	SpanParentChild PICTInputParent = "Child"
 )
 
-// Enumerates the categories of tracestate values that can be generated for a span.
+// PICTInputTracestate enum for the categories of tracestate values that can be generated for a span.
 type PICTInputTracestate string
 
 const (
@@ -96,7 +96,7 @@ const (
 	TraceStateFour  PICTInputTracestate = "Four"
 )
 
-// Enumerates the span kind values that can be set for a span.
+// PICTInputKind enum for the span kind values that can be set for a span.
 type PICTInputKind string
 
 const (
@@ -108,7 +108,7 @@ const (
 	SpanKindConsumer    PICTInputKind = "Consumer"
 )
 
-// Enumerates the categories of representative attributes a generated span can be populated with.
+// PICTInputAttributes enum for the categories of representative attributes a generated span can be populated with.
 type PICTInputAttributes string
 
 const (
@@ -131,7 +131,7 @@ const (
 	SpanAttrMaxCount          PICTInputAttributes = "MaxCount"
 )
 
-// Enumerates the categories of events and/or links a generated span can be populated with.
+// PICTInputSpanChild enum for the categories of events and/or links a generated span can be populated with.
 type PICTInputSpanChild string
 
 const (
@@ -142,7 +142,7 @@ const (
 	SpanChildCountEight PICTInputSpanChild = "Eight"
 )
 
-// Enumerates the status values a generated span can be populated with.
+// PICTInputStatus enum for the status values a generated span can be populated with.
 type PICTInputStatus string
 
 const (
diff --git a/internal/internalconsumertest/err_or_sink_consumer.go b/internal/internalconsumertest/err_or_sink_consumer.go
@@ -48,7 +48,7 @@ func (esc *ErrOrSinkConsumer) ConsumeTraces(ctx context.Context, td pdata.Traces
 	return esc.TracesSink.ConsumeTraces(ctx, td)
 }
 
-// ConsumeTraces stores traces to this sink.
+// ConsumeMetrics stores metrics to this sink.
 func (esc *ErrOrSinkConsumer) ConsumeMetrics(ctx context.Context, md pdata.Metrics) error {
 	esc.mu.Lock()
 	defer esc.mu.Unlock()
diff --git a/internal/processor/filterlog/filterlog.go b/internal/processor/filterlog/filterlog.go
@@ -23,10 +23,10 @@ import (
 	"go.opentelemetry.io/collector/internal/processor/filterset"
 )
 
-// TODO: Modify Matcher to invoke both the include and exclude properties so
-// calling processors will always have the same logic.
 // Matcher is an interface that allows matching a log record against a
 // configuration of a match.
+// TODO: Modify Matcher to invoke both the include and exclude properties so
+//  calling processors will always have the same logic.
 type Matcher interface {
 	MatchLogRecord(lr pdata.LogRecord, resource pdata.Resource, library pdata.InstrumentationLibrary) bool
 }
diff --git a/internal/processor/filtermatcher/attributematcher.go b/internal/processor/filtermatcher/attributematcher.go
@@ -27,7 +27,7 @@ import (
 
 type AttributesMatcher []AttributeMatcher
 
-// attributeMatcher is a attribute key/value pair to match to.
+// AttributeMatcher is a attribute key/value pair to match to.
 type AttributeMatcher struct {
 	Key string
 	// If both AttributeValue and StringFilter are nil only check for key existence.
@@ -79,7 +79,7 @@ func NewAttributesMatcher(config filterset.Config, attributes []filterconfig.Att
 	return rawAttributes, nil
 }
 
-// match attributes specification against a span/log.
+// Match attributes specification against a span/log.
 func (ma AttributesMatcher) Match(attrs pdata.AttributeMap) bool {
 	// If there are no attributes to match against, the span/log matches.
 	if len(ma) == 0 {
diff --git a/internal/processor/filtermatcher/filtermatcher.go b/internal/processor/filtermatcher/filtermatcher.go
@@ -27,7 +27,7 @@ type instrumentationLibraryMatcher struct {
 	Version filterset.FilterSet
 }
 
-// propertiesMatcher allows matching a span against various span properties.
+// PropertiesMatcher allows matching a span against various span properties.
 type PropertiesMatcher struct {
 	// Instrumentation libraries to compare against
 	libraries []instrumentationLibraryMatcher
diff --git a/internal/processor/filterset/regexp/config.go b/internal/processor/filterset/regexp/config.go
@@ -14,7 +14,7 @@
 
 package regexp
 
-// RegexpConfig represents the options for a NewFilterSet.
+// Config represents the options for a NewFilterSet.
 type Config struct {
 	// CacheEnabled determines whether match results are LRU cached to make subsequent matches faster.
 	// Cache size is unlimited unless CacheMaxNumEntries is also specified.
diff --git a/processor/batchprocessor/batch_processor.go b/processor/batchprocessor/batch_processor.go
@@ -217,7 +217,7 @@ func (bp *batchProcessor) ConsumeTraces(_ context.Context, td pdata.Traces) erro
 	return nil
 }
 
-// ConsumeTraces implements MetricsProcessor
+// ConsumeMetrics implements MetricsProcessor
 func (bp *batchProcessor) ConsumeMetrics(_ context.Context, md pdata.Metrics) error {
 	// First thing is convert into a different internal format
 	bp.newItem <- md
diff --git a/receiver/hostmetricsreceiver/internal/scraper/cpuscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/cpuscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for CPU scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "cpu"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/diskscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/diskscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for Disk scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "disk"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for FileSystem scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "filesystem"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_scraper.go b/receiver/hostmetricsreceiver/internal/scraper/filesystemscraper/filesystem_scraper.go
@@ -57,7 +57,6 @@ func newFileSystemScraper(_ context.Context, cfg *Config) (*scraper, error) {
 	return scraper, nil
 }
 
-// Scrape
 func (s *scraper) Scrape(_ context.Context) (pdata.MetricSlice, error) {
 	metrics := pdata.NewMetricSlice()
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/loadscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/loadscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for Load scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "load"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/memoryscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/memoryscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for Memory scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "memory"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper.go b/receiver/hostmetricsreceiver/internal/scraper/memoryscraper/memory_scraper.go
@@ -40,7 +40,6 @@ func newMemoryScraper(_ context.Context, cfg *Config) *scraper {
 	return &scraper{config: cfg, virtualMemory: mem.VirtualMemory}
 }
 
-// Scrape
 func (s *scraper) Scrape(_ context.Context) (pdata.MetricSlice, error) {
 	metrics := pdata.NewMetricSlice()
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/networkscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/networkscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for Network scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "network"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/pagingscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/pagingscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for Paging scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "paging"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/processesscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/processesscraper/factory.go
@@ -26,7 +26,7 @@ import (
 // This file implements Factory for Processes scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "processes"
 )
 
diff --git a/receiver/hostmetricsreceiver/internal/scraper/processscraper/factory.go b/receiver/hostmetricsreceiver/internal/scraper/processscraper/factory.go
@@ -28,7 +28,7 @@ import (
 // This file implements Factory for Process scraper.
 
 const (
-	// The value of "type" key in configuration.
+	// TypeStr the value of "type" key in configuration.
 	TypeStr = "process"
 )
 
diff --git a/receiver/prometheusreceiver/internal/transaction.go b/receiver/prometheusreceiver/internal/transaction.go
@@ -90,7 +90,7 @@ func newTransaction(ctx context.Context, jobsMap *JobsMap, useStartTimeMetric bo
 // ensure *transaction has implemented the storage.Appender interface
 var _ storage.Appender = (*transaction)(nil)
 
-// always returns 0 to disable label caching
+// Add always returns 0 to disable label caching.
 func (tr *transaction) Add(ls labels.Labels, t int64, v float64) (uint64, error) {
 	// Important, must handle. prometheus will still try to feed the appender some data even if it failed to
 	// scrape the remote target,  if the previous scrape was success and some data were cached internally
@@ -114,7 +114,7 @@ func (tr *transaction) Add(ls labels.Labels, t int64, v float64) (uint64, error)
 	return 0, tr.metricBuilder.AddDataPoint(ls, t, v)
 }
 
-// always returns error since caching is not supported by Add() function
+// AddFast always returns error since caching is not supported by Add() function.
 func (tr *transaction) AddFast(_ uint64, _ int64, _ float64) error {
 	return storage.ErrNotFound
 }
@@ -139,7 +139,7 @@ func (tr *transaction) initTransaction(ls labels.Labels) error {
 	return nil
 }
 
-// submit metrics data to consumers
+// Commit submits metrics data to consumers.
 func (tr *transaction) Commit() error {
 	if tr.isNew {
 		// In a situation like not able to connect to the remote server, scrapeloop will still commit even if it had
diff --git a/service/internal/builder/extensions_builder.go b/service/internal/builder/extensions_builder.go
@@ -37,14 +37,14 @@ func (ext *builtExtension) Start(ctx context.Context, host component.Host) error
 	return ext.extension.Start(ctx, host)
 }
 
-// Stop the receiver.
+// Shutdown the receiver.
 func (ext *builtExtension) Shutdown(ctx context.Context) error {
 	return ext.extension.Shutdown(ctx)
 }
 
 var _ component.Extension = (*builtExtension)(nil)
 
-// Exporters is a map of exporters created from exporter configs.
+// Extensions is a map of extensions created from extension configs.
 type Extensions map[config.Extension]*builtExtension
 
 // StartAll starts all exporters.
diff --git a/service/internal/builder/receivers_builder.go b/service/internal/builder/receivers_builder.go
@@ -38,20 +38,20 @@ type builtReceiver struct {
 	receiver component.Receiver
 }
 
-// Start the receiver.
+// Start starts the receiver.
 func (rcv *builtReceiver) Start(ctx context.Context, host component.Host) error {
 	return rcv.receiver.Start(ctx, host)
 }
 
-// Stop the receiver.
+// Shutdown stops the receiver.
 func (rcv *builtReceiver) Shutdown(ctx context.Context) error {
 	return rcv.receiver.Shutdown(ctx)
 }
 
 // Receivers is a map of receivers created from receiver configs.
 type Receivers map[config.Receiver]*builtReceiver
 
-// StopAll stops all receivers.
+// ShutdownAll stops all receivers.
 func (rcvs Receivers) ShutdownAll(ctx context.Context) error {
 	var errs []error
 	for _, rcv := range rcvs {
diff --git a/service/internal/zpages/templates.go b/service/internal/zpages/templates.go
diff --git a/testbed/correctness/metrics/doc.go b/testbed/correctness/metrics/doc.go
diff --git a/testbed/testbed/child_process.go b/testbed/testbed/child_process.go
diff --git a/testbed/testbed/otelcol_runner.go b/testbed/testbed/otelcol_runner.go
diff --git a/testbed/testbed/receivers.go b/testbed/testbed/receivers.go
diff --git a/testbed/testbed/results.go b/testbed/testbed/results.go
diff --git a/testbed/tests/scenarios.go b/testbed/tests/scenarios.go
diff --git a/translator/trace/zipkin/attributekeys.go b/translator/trace/zipkin/attributekeys.go
diff --git a/translator/trace/zipkin/zipkinv1_to_protospan.go b/translator/trace/zipkin/zipkinv1_to_protospan.go
diff --git a/translator/trace/zipkin/zipkinv1_to_protospan_test.go b/translator/trace/zipkin/zipkinv1_to_protospan_test.go

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func (f *nopExporterFactory) CreateMetricsExporter(`
`63`	`63`	`return nopExporterInstance, nil`
`64`	`64`	`}`
`65`	`65`
`66`		`-// CreateMetricsExporter implements component.ExporterFactory interface.`
	`66`	`+// CreateLogsExporter implements component.ExporterFactory interface.`
`67`	`67`	`func (f *nopExporterFactory) CreateLogsExporter(`
`68`	`68`	`_ context.Context,`
`69`	`69`	`_ component.ExporterCreateParams,`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func (f *nopProcessorFactory) CreateMetricsProcessor(`
`68`	`68`	`return nopProcessorInstance, nil`
`69`	`69`	`}`
`70`	`70`
`71`		`-// CreateMetricsProcessor implements component.ProcessorFactory interface.`
	`71`	`+// CreateLogsProcessor implements component.ProcessorFactory interface.`
`72`	`72`	`func (f *nopProcessorFactory) CreateLogsProcessor(`
`73`	`73`	`_ context.Context,`
`74`	`74`	`_ component.ProcessorCreateParams,`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ func (f *nopReceiverFactory) CreateMetricsReceiver(`
`65`	`65`	`return nopReceiverInstance, nil`
`66`	`66`	`}`
`67`	`67`
`68`		`-// CreateMetricsReceiver implements component.ReceiverFactory interface.`
	`68`	`+// CreateLogsReceiver implements component.ReceiverFactory interface.`
`69`	`69`	`func (f *nopReceiverFactory) CreateLogsReceiver(`
`70`	`70`	`_ context.Context,`
`71`	`71`	`_ component.ReceiverCreateParams,`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ type headerRoundTripper struct {`
`95`	`95`	`headers map[string]string`
`96`	`96`	`}`
`97`	`97`
`98`		`-// Custom RoundTrip that add headers`
	`98`	`+// RoundTrip is a custom RoundTripper that adds headers to the request.`
`99`	`99`	`func (interceptor headerRoundTripper) RoundTrip(req http.Request) (*http.Response, error) {`
`100`	`100`	`for k, v := range interceptor.headers {`
`101`	`101`	`req.Header.Set(k, v)`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func newCollector(config Config, logger zap.Logger) *collector {`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`
`46`		`-// Collector dynamically allocates metrics, describe shoud be noop`
	`46`	`+// Describe is a no-op, because the collector dynamically allocates metrics.`
`47`	`47`	`// https://github.com/prometheus/client_golang/blob/v1.9.0/prometheus/collector.go#L28-L40`
`48`	`48`	`func (c collector) Describe(_ chan<- prometheus.Desc) {}`
`49`	`49`
Original file line number	Diff line number	Diff line change
`@@ -51,15 +51,15 @@ const (`
`51`	`51`	`LabelsMany PICTNumPtLabels = "ManyLabels"`
`52`	`52`	`)`
`53`	`53`
`54`		`-// Enumerates the number of points on each metric.`
	`54`	`+// PICTNumPtsPerMetric enum for the number of points on each metric.`
`55`	`55`	`type PICTNumPtsPerMetric string`
`56`	`56`
`57`	`57`	`const (`
`58`	`58`	`NumPtsPerMetricOne PICTNumPtsPerMetric = "OnePt"`
`59`	`59`	`NumPtsPerMetricMany PICTNumPtsPerMetric = "ManyPts"`
`60`	`60`	`)`
`61`	`61`
`62`		`-// Enumerates the number of attributes on each resource.`
	`62`	`+// PICTNumResourceAttrs enum for the number of attributes on each resource.`
`63`	`63`	`type PICTNumResourceAttrs string`
`64`	`64`
`65`	`65`	`const (`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func (esc *ErrOrSinkConsumer) ConsumeTraces(ctx context.Context, td pdata.Traces`
`48`	`48`	`return esc.TracesSink.ConsumeTraces(ctx, td)`
`49`	`49`	`}`
`50`	`50`
`51`		`-// ConsumeTraces stores traces to this sink.`
	`51`	`+// ConsumeMetrics stores metrics to this sink.`
`52`	`52`	`func (esc *ErrOrSinkConsumer) ConsumeMetrics(ctx context.Context, md pdata.Metrics) error {`
`53`	`53`	`esc.mu.Lock()`
`54`	`54`	`defer esc.mu.Unlock()`
Original file line number	Diff line number	Diff line change
`@@ -23,10 +23,10 @@ import (`
`23`	`23`	`"go.opentelemetry.io/collector/internal/processor/filterset"`
`24`	`24`	`)`
`25`	`25`
`26`		`-// TODO: Modify Matcher to invoke both the include and exclude properties so`
`27`		`-// calling processors will always have the same logic.`
`28`	`26`	`// Matcher is an interface that allows matching a log record against a`
`29`	`27`	`// configuration of a match.`
	`28`	`+// TODO: Modify Matcher to invoke both the include and exclude properties so`
	`29`	`+// calling processors will always have the same logic.`
`30`	`30`	`type Matcher interface {`
`31`	`31`	`MatchLogRecord(lr pdata.LogRecord, resource pdata.Resource, library pdata.InstrumentationLibrary) bool`
`32`	`32`	`}`