Undefined references / API breakage

[samuelvenable]

I am trying to update SHADERed by dfranx: https://github.com/dfranx/SHADERed

to use my fork of his ImFileDialog library: https://github.com/samuelvenable/ImFileDialog

I am using the version of ImGui that comes with the master branch of SHADERed: https://github.com/dfranx/imgui/tree/b29c8de3d045410cd73a6a708d6bc2ab41c30426

These are the remaining errors I'm getting. I have no idea why there are undefined symbols simply by changing ImGui version. I've noticed over the years you are constantly causing API breakage by changing things and how they are implemented abruptly and without warning, thus breaking existing code. I'm assuming this is just another occurance of that at work here...

What equivalent functions/features do I need to use to get it to compile?

Errors are from this file: https://github.com/samuelvenable/ImFileDialog/blob/main/ImFileDialog.cpp

Edit:

I've noticed some of these errors explain what the code should be changed to, but not all of them do.

ld: error: undefined symbol: ImGui::InvisibleButton(char const*, ImVec2 const&, int)
>>> referenced by ImFileDialog.cpp:115
>>>               ImFileDialog.cpp.o:(ifd::FolderNode(char const*, unsigned long long, bool&)) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced by ImFileDialog.cpp:151
>>>               ImFileDialog.cpp.o:(ifd::FileNode(char const*, unsigned long long)) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced by ImFileDialog.cpp:307
>>>               ImFileDialog.cpp.o:(ifd::FavoriteButton(char const*, bool)) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced 1 more times
>>> did you mean: ImGui::InvisibleButton(char const*, ImVec2 const&)
>>> defined in: CMakeFiles/SHADERed.dir/libs/imgui/imgui_widgets.cpp.o

ld: error: undefined symbol: ImGui::RenderArrow(ImDrawList*, ImVec2, unsigned int, ImGuiDir, float)
>>> referenced by ImFileDialog.cpp:137
>>>               ImFileDialog.cpp.o:(ifd::FolderNode(char const*, unsigned long long, bool&)) in archive libs/ImFileDialog/libImFileDialog.a

ld: error: undefined symbol: ImDrawList::AddImage(unsigned long long, ImVec2 const&, ImVec2 const&, ImVec2 const&, ImVec2 const&, unsigned int)
>>> referenced by ImFileDialog.cpp:138
>>>               ImFileDialog.cpp.o:(ifd::FolderNode(char const*, unsigned long long, bool&)) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced by ImFileDialog.cpp:159
>>>               ImFileDialog.cpp.o:(ifd::FileNode(char const*, unsigned long long)) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced by ImFileDialog.cpp:394
>>>               ImFileDialog.cpp.o:(ifd::FileIcon(char const*, bool, unsigned long long, ImVec2, bool, int, int)) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced 1 more times

ld: error: undefined symbol: ImGui::ArrowButtonEx(char const*, ImGuiDir, ImVec2, int)
>>> referenced by ImFileDialog.cpp:220
>>>               ImFileDialog.cpp.o:(ifd::PathBox(char const*, ghc::filesystem::path&, char*, ImVec2)) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced by ImFileDialog.cpp:1863
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderFileDialog()) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced by ImFileDialog.cpp:1874
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderFileDialog()) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced 1 more times

ld: error: undefined symbol: ImDrawList::AddText(ImFont*, float, ImVec2 const&, unsigned int, char const*, char const*, float, ImVec4 const*)
>>> referenced by ImFileDialog.cpp:398
>>>               ImFileDialog.cpp.o:(ifd::FileIcon(char const*, bool, unsigned long long, ImVec2, bool, int, int)) in archive libs/ImFileDialog/libImFileDialog.a

ld: error: undefined symbol: ImGui::BeginChild(char const*, ImVec2 const&, int, int)
>>> referenced by ImFileDialog.cpp:1919
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderFileDialog()) in archive libs/ImFileDialog/libImFileDialog.a
>>> referenced by ImFileDialog.cpp:1926
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderFileDialog()) in archive libs/ImFileDialog/libImFileDialog.a

ld: error: undefined symbol: ImGui::IsKeyPressed(ImGuiKey, bool)
>>> referenced by ImFileDialog.cpp:1974
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderFileDialog()) in archive libs/ImFileDialog/libImFileDialog.a

ld: error: undefined symbol: ImGui::TableSetupScrollFreeze(int, int)
>>> referenced by ImFileDialog.cpp:1640
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderContent()) in archive libs/ImFileDialog/libImFileDialog.a

ld: error: undefined symbol: ImGui::TableHeadersRow()
>>> referenced by ImFileDialog.cpp:1641
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderContent()) in archive libs/ImFileDialog/libImFileDialog.a

ld: error: undefined symbol: ImGui::Image(unsigned long long, ImVec2 const&, ImVec2 const&, ImVec2 const&)
>>> referenced by ImFileDialog.cpp:1664
>>>               ImFileDialog.cpp.o:(ifd::FileDialog::m_renderContent()) in archive libs/ImFileDialog/libImFileDialog.a

ld: error: undefined symbol: ImDrawList::AddPolyline(ImVec2 const*, int, unsigned int, int, float)
>>> referenced by imgui.h:3198 (libs/imgui/imgui.h:3198)
>>>               ImFileDialog.cpp.o:(ImDrawList::PathStroke(unsigned int, int, float)) in archive libs/ImFileDialog/libImFileDialog.a

What puzzles me is that is says "did you mean: ImGui::InvisibleButton(two arguments and not three)" but everywhere in the file I am already using two arguments and not three. So it's unclear why it is showing that error to begin with.

Thank you!
Samuel

[ocornut]

I've noticed over the years you are constantly causing API breakage by changing things and how they are implemented abruptly and without warning,

Everything is carefully documented in "API BREAKING CHANGES" section of imgui.cpp + Changelog.txt + release notes.

What puzzles me is that is says "did you mean: ImGui::InvisibleButton(two arguments and not three)" but everywhere in the file I am already using two arguments and not three. So it's unclear why it is showing that error to begin with

4929a8e (released august 2020, almost 5 years ago) added a third default parameter to InvisibleButton():

bool  InvisibleButton(const char* str_id, const ImVec2& size, ImGuiButtonFlags flags = 0)

So it has 3 parameters since 5 years but the 3rd one may be omitted by call site.

Indeed https://github.com/dfranx/imgui/tree/b29c8de3d045410cd73a6a708d6bc2ab41c30426 uses a very old version but this particular error should update without an issue.

I have no idea why you have a linking error here and others. The errors suggest you may have another issue with your build system or setup. I believe you may be using new header files but linking with old compiled files from the old version.

[ocornut]

Other errors are of the same nature, except the table ones which are due to not compiling and linking with imgui_tables.cpp which was introduced in 1.80.