Group scons targets better (#18885)

Fixup of #18880
Summary of the issue:

#18880 broke signed builds, as building the controller client requires signing, and #18880 tried to build the controller client without signpath installed.

It also failed to fix #18867 properly, as the full user_docs was not built until scons launcher was called
Description of user facing changes:

None
Description of developer facing changes:

Fixed #18880 properly
Description of development approach:

    Build all docs in a grouped job
    Build client & launcher in a separate job

Author: seanbudd

.github/workflows/testAndPublish.yml

@@ -340,17 +340,17 @@ jobs:
       run: ci/scripts/setSconsArgs.ps1
       env:
         apiSigningToken: ${{ github.event_name == 'push' && secrets.API_SIGNING_TOKEN || '' }}
-    - name: Build scons targets
+    - name: Build scons docs targets
       shell: cmd
-      run: scons %sconsOutTargets% %sconsArgs% %sconsCores%
-    - name: Create launcher
+      run: scons %sconsDocsOutTargets% %sconsArgs% %sconsCores%
+    # Run launcher separately as we can't safely generate that in parallel to docs scons targets (#18867)
+    - name: Create launcher and controller client
       shell: cmd
-      # Run launcher separately as we can't safely generate that in parallel to other scons targets (#18867)
       run: |
         PowerShell -Command "Set-ExecutionPolicy Bypass"
         PowerShell -Command "Set-PSRepository PSGallery -InstallationPolicy Trusted"
         PowerShell -Command "Install-Module -Name SignPath -Force"
-        scons launcher %sconsArgs% %sconsCores%
+        scons %sconsLauncherOutTargets% %sconsArgs% %sconsCores%
     - name: Upload launcher
       id: uploadLauncher
       uses: actions/upload-artifact@v4

ci/scripts/setSconsArgs.ps1

@@ -1,5 +1,6 @@
 $ErrorActionPreference = "Stop";
-$sconsOutTargets = "developerGuide changes userGuide keyCommands client moduleList"
+$sconsDocsOutTargets = "developerGuide changes userGuide keyCommands user_docs"
+$sconsLauncherOutTargets = "launcher client moduleList"
 $sconsArgs = "version=$env:version"
 $sconsCores = "--all-cores"
 if ($env:RUNNER_DEBUG -eq "1") {
@@ -20,9 +21,11 @@ if ($env:GITHUB_EVENT_NAME -eq "push" -and $env:apiSigningToken) {
 	$sconsArgs += " apiSigningToken=$env:apiSigningToken"
 }
 $sconsArgs += " version_build=$([int]$env:GITHUB_RUN_NUMBER + [int]$env:START_BUILD_NUMBER)"
-Write-Output "sconsOutTargets=$sconsOutTargets" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+Write-Output "sconsDocsOutTargets=$sconsDocsOutTargets" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
+Write-Output "sconsLauncherOutTargets=$sconsLauncherOutTargets" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
 Write-Output "sconsArgs=$sconsArgs" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
 Write-Output "sconsCores=$sconsCores" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
 Write-Host "scons args: $sconsArgs"
-Write-Host "scons output targets: $sconsOutTargets"
+Write-Host "scons docs output targets: $sconsDocsOutTargets"
+Write-Host "scons launcher output targets: $sconsLauncherOutTargets"
 Write-Host "scons cores: $sconsCores"