fix: retrieve numaflow-java SDK version instead of java SDK version (#40)

Update the getSDKVersion() implementation to read current numaflow-java version from the maven pom.xml file.

Signed-off-by: Keran Yang <[email protected]>

Author: KeranYang

examples/src/main/java/io/numaproj/numaflow/examples/function/map/evenodd/EvenOddFunction.java

@@ -30,10 +30,10 @@ public MessageList processMessage(String[] keys, Datum data) {
             return MessageList.newBuilder().addMessage(Message.toDrop()).build();
         }
 
-        String[] outputKeys = value % 2 == 0 ? new String[]{"even"} : new String[]{"odd"};
+        String[] outputKeys = value % 2 == 0 ? new String[]{"even"}:new String[]{"odd"};
 
         // tags will be used for conditional forwarding
-        String[] tags = value % 2 == 0 ? new String[]{"even-tag"} : new String[]{"odd-tag"};
+        String[] tags = value % 2 == 0 ? new String[]{"even-tag"}:new String[]{"odd-tag"};
 
         return MessageList
                 .newBuilder()

examples/src/main/java/io/numaproj/numaflow/examples/sink/simple/SimpleSink.java

@@ -8,7 +8,6 @@
 import io.numaproj.numaflow.sink.SinkServer;
 import lombok.extern.slf4j.Slf4j;
 
-
 /**
  * This is a simple User Defined Sink example which logs the input message
  */

pom.xml

@@ -249,5 +249,11 @@
                 </plugin>
             </plugins>
         </pluginManagement>
+        <resources>
+            <resource>
+                <directory>src/main/java/io/numaproj/numaflow/info</directory>
+                <filtering>true</filtering>
+            </resource>
+        </resources>
     </build>
 </project>

src/main/java/io/numaproj/numaflow/info/ServerInfoAccessor.java

@@ -2,7 +2,7 @@
 
 public interface ServerInfoAccessor {
     /**
-     * Get runtime Java SDK version.
+     * Get current runtime numaflow-java SDK version.
      */
     String getSDKVersion();
 

src/main/java/io/numaproj/numaflow/info/ServerInfoAccessorImpl.java

@@ -5,18 +5,31 @@
 
 import java.io.File;
 import java.io.FileWriter;
+import java.io.IOException;
+import java.io.InputStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.Properties;
 
 @AllArgsConstructor
 public class ServerInfoAccessorImpl implements ServerInfoAccessor {
     private ObjectMapper objectMapper;
 
     @Override
     public String getSDKVersion() {
-        // This only works for Java 9 and above.
-        // Since we already use 11+ for numaflow SDK, it's safe to apply this approach.
-        return String.valueOf(Runtime.version().version().get(0));
+        String version = "";
+        try (InputStream in = getClass()
+                .getClassLoader()
+                .getResourceAsStream("version.properties")) {
+            if (in != null) {
+                Properties properties = new Properties();
+                properties.load(in);
+                version = properties.getProperty("sdk.version");
+            }
+        } catch (IOException e) {
+            return version;
+        }
+        return version;
     }
 
     @Override

src/main/java/io/numaproj/numaflow/info/version.properties

@@ -0,0 +1 @@
+sdk.version=${project.version}

src/test/java/io/numaproj/numaflow/info/ServerInfoAccessorImplTest.java

@@ -8,30 +8,25 @@
 import java.util.HashMap;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 @RunWith(JUnit4.class)
 public class ServerInfoAccessorImplTest {
     private ServerInfoAccessor underTest = new ServerInfoAccessorImpl(new ObjectMapper());
 
     @Test
-    public void given_localEnvironment_when_getJavaSDKVersion_then_returnAValidVersion() {
+    public void given_localEnvironment_when_getNumaflowJavaSDKVersion_then_returnAValidVersion() {
         String got = this.underTest.getSDKVersion();
-        assertNotEquals("", got);
-        try {
-            Integer.parseInt(got);
-        } catch (NumberFormatException e) {
-            fail("Expected java SDK version to be a valid integer.");
-        }
+        assertTrue(got.matches("^\\d+\\.\\d+\\.\\d+$"));
     }
 
     @Test
     public void given_writeServerInfo_when_read_then_returnExactSame() {
         ServerInfo testServerInfo = new ServerInfo(
                 Protocol.TCP_PROTOCOL,
                 Language.JAVA,
-                "11",
+                "0.4.3",
                 new HashMap<>() {{
                     put("key1", "value1");
                     put("key2", "value2");