Skip to content

Commit ce13b44

Browse files
fixed incorrect SNAPSHOT version checking logic for check operation
1 parent 5fc9d97 commit ce13b44

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

CHANGELOG.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,14 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
55
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
66

7-
## [Unreleased]
7+
## 1.3.4 - 2017-10-03
8+
### Fixed
9+
- v1.3.3 introduced [Incorrect SNAPSHOT version checking logic](https://github.com/patrickcrocker/maven-resource/issues/12) for the `check` operation for snapshots but was quickly spotted by [@shinmyung0](https://github.com/shinmyung0). This is now fixed and the 1.3.3 release has been yanked!
10+
11+
### Removed
12+
- Version 1.3.3 (use 1.3.4 instead!!)
813

9-
## 1.3.3 - 2017-10-03
14+
## 1.3.3 - 2017-10-03 [YANKED]
1015
### Added
1116
- Change log file (CHANGELOG.md).
1217
- Generate release notes from CHANGELOG.me for github release (pipeline.yml).

assets/in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ fi
8686

8787
# test for 1.0.0-SNAPSHOT and for 1.0.0-20170328.031519-19
8888
isSnapshot=false
89-
[[ "$version" = *-SNAPSHOT ]] && echo "$version" | grep -oEq "[0-9]{8}\.[0-9]{6}-[0-9]{1,}" && isSnapshot=true
89+
[[ "$version" = *-SNAPSHOT ]] || echo "$version" | grep -oEq "[0-9]{8}\.[0-9]{6}-[0-9]{1,}" && isSnapshot=true
9090

9191
url=$release_url
9292
[ -n "$snapshot_url" ] && [ "$isSnapshot" = true ] && url=$snapshot_url

0 commit comments

Comments
 (0)