Merge branch 'filter-archived-versions'

Author: shomatan

dist/appsscript.json

@@ -1,5 +1,5 @@
 {
-  "timeZone": "America/New_York",
+  "timeZone": "Asia/Tokyo",
   "dependencies": {
   },
   "exceptionLogging": "STACKDRIVER"

src/BacklogClient.spec.ts

@@ -119,6 +119,16 @@ describe("BacklogClient", function () {
           "archived": false,
           "displayOrder": 0
         },
+        {
+          "id": 121209,
+          "projectId": 12345,
+          "name": "0.1.0",
+          "description": null,
+          "startDate": null,
+          "releaseDueDate": null,
+          "archived": true,
+          "displayOrder": 2
+        },
         {
           "id": 121213,
           "projectId": 12345,
@@ -127,7 +137,7 @@ describe("BacklogClient", function () {
           "startDate": null,
           "releaseDueDate": null,
           "archived": false,
-          "displayOrder": 1
+          "displayOrder": 3
         }]`
     }
 

src/BacklogClient.ts

@@ -197,7 +197,9 @@ export class BacklogClientImpl implements BacklogClient {
 
   public getVersionsV2(id: Id<Project>): Version[] {
     const json = this.http.get(this.buildUri(`projects/${id}/versions`))
-    return Object.keys(json).map(key => this.jsonTo(json[key]))
+    return Object.keys(json)
+      .filter(key => !json[key]["archived"])
+      .map(key => this.jsonTo(json[key]))
   }
 
   public getPrioritiesV2(): Priority[] {

src/BacklogService.ts

@@ -13,12 +13,16 @@ const ROW_HEADER_INDEX = 1
 const COLUMN_START_INDEX = 1 /** データ列の開始インデックス */
 const ROW_START_INDEX = 2    /** データ行の開始インデックス */
 const DEFAULT_COLUMN_LENGTH = 16
+const MAX_LIST_ITEM_COUNT = 500
 
 type Validation<A> = (a: A, onError: Error) => Either<Error, A>
 
 const isEmpty: Validation<string> = (str: string, onError: Error): Either<Error, string> =>
   str !== "" ? Right(str) : Left(onError)
 
+const slice = <A>(items: A[]): A[] =>
+  items.slice(0, MAX_LIST_ITEM_COUNT - 1)
+
 const createBacklogClient = (space: string, domain: string, apiKey: string, locale: Locale): Either<Error, BacklogClient> => {
   const spaceResult = isEmpty(space, Error(Message.SPACE_URL_REQUIRED(locale)))
   const apiKeyResult = isEmpty(apiKey, Error(Message.API_KEY_REQUIRED(locale)))
@@ -289,16 +293,16 @@ export const BacklogService = (spreadSheetService: SpreadSheetService): BacklogS
     showMessage(Message.PROGRESS_INIT_BEGIN(locale), spreadSheetService)
     return createBacklogClient(property.space, property.domain, property.apiKey, locale)
       .flatMap(client =>
-        getProject(client, property.projectKey, locale).map(project =>
-          BacklogDefinition(
-            client.getIssueTypesV2(project.id),
-            client.getCategoriesV2(project.id),
-            client.getVersionsV2(project.id),
-            client.getPrioritiesV2(),
-            client.getUsersV2(project.id),
-            client.getCustomFieldsV2(project.id)
-          )
-        )
+        getProject(client, property.projectKey, locale).map(project => {
+          const issueTypes = client.getIssueTypesV2(project.id)
+          const categories = client.getCategoriesV2(project.id)
+          const versions = client.getVersionsV2(project.id)
+          const priorities = client.getPrioritiesV2()
+          const users = client.getUsersV2(project.id)
+          const customFields = client.getCustomFieldsV2(project.id)
+
+          return BacklogDefinition(slice(issueTypes), slice(categories), slice(versions), slice(priorities), slice(users), customFields)
+        })
       )
       .map(definition => {
         const issueTypeRule = SpreadsheetApp.newDataValidation().requireValueInList(definition.issueTypeNames(), true).build()