fix: Add null check on body on 401 errors

plchampigny · isaacs · commit e3a0186ffd0d · 2019-10-03T17:18:55.000-07:00
PR-URL: #9 Credit: @plchampigny Close: #9 Reviewed-by: @isaacs
diff --git a/check-response.js b/check-response.js
@@ -95,7 +95,7 @@ function checkErrors (method, res, startTime, opts) {
             method, res, parsed, opts.spec
           )
         }
-      } else if (res.status === 401 && /one-time pass/.test(body.toString('utf8'))) {
+      } else if (res.status === 401 && body != null && /one-time pass/.test(body.toString('utf8'))) {
         // Heuristic for malformed OTP responses that don't include the www-authenticate header.
         throw new errors.HttpErrorAuthOTP(
           method, res, parsed, opts.spec

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ function checkErrors (method, res, startTime, opts) {`
`95`	`95`	`method, res, parsed, opts.spec`
`96`	`96`	`)`
`97`	`97`	`}`
`98`		`- } else if (res.status === 401 && /one-time pass/.test(body.toString('utf8'))) {`
	`98`	`+ } else if (res.status === 401 && body != null && /one-time pass/.test(body.toString('utf8'))) {`
`99`	`99`	`// Heuristic for malformed OTP responses that don't include the www-authenticate header.`
`100`	`100`	`throw new errors.HttpErrorAuthOTP(`
`101`	`101`	`method, res, parsed, opts.spec`