fix: server restart hanging

Author: adamkirchberger

pytest_netconf/netconfserver.py

@@ -231,6 +231,7 @@ def start(self) -> None:
             OSError: If the server fails to bind to the specified port.
         """
         self.running = True
+        self._hello_sent = False  # reset in case of restart
         self._bind_socket()
         self._thread = threading.Thread(target=self._run)
         self._thread.start()

tests/integration/test_ncclient.py

@@ -292,4 +292,30 @@ def test_when_connecting_using_username_and_wrong_key_then_authentication_fails(
             ...
 
     # THEN expect error
-    assert error
+    assert error
+
+
+def test_when_server_restarted_then_connection_passes(netconf_server: NetconfServer):
+    # GIVEN initial connection to server
+    with manager.connect(
+        host="localhost",
+        port=8830,
+        username="admin",
+        password="admin",
+        hostkey_verify=False,
+    ) as m:
+        assert m.connected
+
+    # WHEN server is stopped and then started again
+    netconf_server.stop()
+    netconf_server.start()
+
+    # THEN expect reconnection to succeed
+    with manager.connect(
+        host="localhost",
+        port=8830,
+        username="admin",
+        password="admin",
+        hostkey_verify=False,
+    ) as m:
+        assert m.connected