From 10f694e9c6e84c08aba3f91455d9c44dc718320f Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Mon, 25 Nov 2024 11:49:27 -0300 Subject: [PATCH 1/2] doc: add FAQ to releases section --- doc/contributing/releases.md | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 3ae682169873df..a37db1c8da5242 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -1383,6 +1383,42 @@ Infrastructure team is able to perform the switch of the default. An issue should be opened on the [Node.js Snap management repository][] requesting this take place once a new LTS line has been released. +## FAQ + +Due to how releases work (tools/release.sh) isn't uncommon to face some errors +during the promotion process as it depends on network communication and machine +availability. This section aims to guide the releaser through potential +failures. + +### Error on dist-indexer while promoting + +```bash +node:events:491 + throw er; // Unhandled 'error' event + ^ + +Error: read ECONNRESET + at TLSWrap.onStreamRead (node:internal/stream_base_commons:217:20) +Emitted 'error' event on DestroyableTransform instance at: + at ClientRequest. (/usr/lib/node_modules/nodejs-dist-indexer/node_modules/hyperquest/index.js:14:19) + at ClientRequest.emit (node:events:513:28) + at TLSSocket.socketErrorListener (node:_http_client:494:9) + at TLSSocket.emit (node:events:513:28) + at emitErrorNT (node:internal/streams/destroy:157:8) + at emitErrorCloseNT (node:internal/streams/destroy:122:3) + at processTicksAndRejections (node:internal/process/task_queues:83:21) { + errno: -104, + code: 'ECONNRESET', + syscall: 'read' +} +``` + +Typical approach: Sign the release again + +```bash +./tools/release.sh -s vX.Y.Z +``` + [Build issue tracker]: https://github.com/nodejs/build/issues/new [CI lockdown procedure]: https://github.com/nodejs/build/blob/HEAD/doc/jenkins-guide.md#restricting-access-for-security-releases [Node.js Snap management repository]: https://github.com/nodejs/snap From 0bb2fc4cc5794dabbc772d213d193fcd813bea51 Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga Date: Tue, 26 Nov 2024 10:29:00 -0300 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Antoine du Hamel --- doc/contributing/releases.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index a37db1c8da5242..32e9880b444dcb 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -1385,7 +1385,7 @@ take place once a new LTS line has been released. ## FAQ -Due to how releases work (tools/release.sh) isn't uncommon to face some errors +Due to how `tools/release.sh` work, it isn't uncommon to face some errors during the promotion process as it depends on network communication and machine availability. This section aims to guide the releaser through potential failures. @@ -1413,7 +1413,7 @@ Emitted 'error' event on DestroyableTransform instance at: } ``` -Typical approach: Sign the release again +Typical resolution: sign the release again. ```bash ./tools/release.sh -s vX.Y.Z