From a976f3ca4b7d1fc469484e3cedfad7eb44c56db8 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Fri, 2 Aug 2024 10:20:40 -0300 Subject: [PATCH 1/2] benchmark: use assert.ok instead of assert --- benchmark/buffers/buffer-atob.js | 2 +- benchmark/buffers/buffer-btoa.js | 2 +- benchmark/buffers/buffer-iterate.js | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/benchmark/buffers/buffer-atob.js b/benchmark/buffers/buffer-atob.js index 2cc20759e3f0f6..ee986e49e5e9ae 100644 --- a/benchmark/buffers/buffer-atob.js +++ b/benchmark/buffers/buffer-atob.js @@ -16,5 +16,5 @@ function main({ n, size }) { out += atob(input).length; } bench.end(n); - assert(out > 0); + assert.ok(out > 0); } diff --git a/benchmark/buffers/buffer-btoa.js b/benchmark/buffers/buffer-btoa.js index 3867d5890b1d79..5bfe7cff3db179 100644 --- a/benchmark/buffers/buffer-btoa.js +++ b/benchmark/buffers/buffer-btoa.js @@ -16,5 +16,5 @@ function main({ n, size }) { out += btoa(input).length; } bench.end(n); - assert(out > 0); + assert.ok(out > 0); } diff --git a/benchmark/buffers/buffer-iterate.js b/benchmark/buffers/buffer-iterate.js index 57a15e42249742..31f9b9985f72cd 100644 --- a/benchmark/buffers/buffer-iterate.js +++ b/benchmark/buffers/buffer-iterate.js @@ -31,7 +31,7 @@ function main({ size, type, method, n }) { function benchFor(buffer, n) { for (let k = 0; k < n; k++) { for (let i = 0; i < buffer.length; i++) { - assert(buffer[i] === 0); + assert.ok(buffer[i] === 0); } } } @@ -39,7 +39,7 @@ function benchFor(buffer, n) { function benchForOf(buffer, n) { for (let k = 0; k < n; k++) { for (const b of buffer) { - assert(b === 0); + assert.ok(b === 0); } } } @@ -50,7 +50,7 @@ function benchIterator(buffer, n) { let cur = iter.next(); while (!cur.done) { - assert(cur.value === 0); + assert.ok(cur.value === 0); cur = iter.next(); } From 5d58bf4d0121576c0ef4e72ffb0e533c52dc0dee Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Fri, 2 Aug 2024 15:36:37 -0300 Subject: [PATCH 2/2] fixup! apply cr suggestions --- benchmark/buffers/buffer-iterate.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/benchmark/buffers/buffer-iterate.js b/benchmark/buffers/buffer-iterate.js index 31f9b9985f72cd..c1c4f6917501a1 100644 --- a/benchmark/buffers/buffer-iterate.js +++ b/benchmark/buffers/buffer-iterate.js @@ -31,7 +31,7 @@ function main({ size, type, method, n }) { function benchFor(buffer, n) { for (let k = 0; k < n; k++) { for (let i = 0; i < buffer.length; i++) { - assert.ok(buffer[i] === 0); + assert.strictEqual(buffer[i], 0); } } } @@ -39,7 +39,7 @@ function benchFor(buffer, n) { function benchForOf(buffer, n) { for (let k = 0; k < n; k++) { for (const b of buffer) { - assert.ok(b === 0); + assert.strictEqual(b, 0); } } } @@ -50,7 +50,7 @@ function benchIterator(buffer, n) { let cur = iter.next(); while (!cur.done) { - assert.ok(cur.value === 0); + assert.strictEqual(cur.value, 0); cur = iter.next(); }