fixup! fixup! src,node-api: fatal errors should not assume a current isolate may exist

legendecas · legendecas · commit fc0390cdbefe · 2021-05-16T16:47:25.000+08:00
diff --git a/src/node_errors.cc b/src/node_errors.cc
@@ -428,6 +428,7 @@ void OnFatalError(const char* location, const char* message) {
   // TODO(legendecas): investigate failures on triggering node-report with
   // nullptr isolates.
   if (isolate == nullptr) {
+    fflush(stderr);
     ABORT();
   }
   Environment* env = Environment::GetCurrent(isolate);

Original file line number	Diff line number	Diff line change
`@@ -428,6 +428,7 @@ void OnFatalError(const char* location, const char* message) {`
`428`	`428`	`// TODO(legendecas): investigate failures on triggering node-report with`
`429`	`429`	`// nullptr isolates.`
`430`	`430`	`if (isolate == nullptr) {`
	`431`	`+ fflush(stderr);`
`431`	`432`	`ABORT();`
`432`	`433`	`}`
`433`	`434`	`Environment* env = Environment::GetCurrent(isolate);`