Skip to content

Commit f7d96ac

Browse files
danbevMylesBorins
authored andcommitted
http2: pass session to DEBUG_HTTP2SESSION2
When configure with --debug-http2 --debug-nghttp2 the following compilation error is generated: DEBUG_HTTP2SESSION2(this, "fatal error receiving data: %d", ret); ^ ../src/node_http2.cc:1690:27: error: invalid use of 'this' outside of a non-static member function 1 errors generated. OnStreamReadImpl is static and I think the intention was to pass in the session variable here. PR-URL: #20815 Refs: #20806 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
1 parent 0829b54 commit f7d96ac

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_http2.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1687,7 +1687,7 @@ void Http2Session::OnStreamReadImpl(ssize_t nread,
16871687
// ssize_t to int. Cast here so that the < 0 check actually works on
16881688
// Windows.
16891689
if (static_cast<int>(ret) < 0) {
1690-
DEBUG_HTTP2SESSION2(this, "fatal error receiving data: %d", ret);
1690+
DEBUG_HTTP2SESSION2(session, "fatal error receiving data: %d", ret);
16911691

16921692
Local<Value> argv[1] = {
16931693
Integer::New(isolate, ret),

0 commit comments

Comments
 (0)