Skip to content

Commit e4224fd

Browse files
Shivang44MylesBorins
authored andcommitted
test: improve path tests
Replaced deepStrictEqual with strictEqual when asserting that the path is equal to the win32 or posix equivalent, since it is a more strict check than deepStrictCheck. Also removed third argument in the check so that if there is an assertion error the properties that are different will be displayed. PR-URL: #20967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f2c9e5a commit e4224fd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-path.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,6 @@ assert.strictEqual(path.win32.delimiter, ';');
6868
assert.strictEqual(path.posix.delimiter, ':');
6969

7070
if (common.isWindows)
71-
assert.deepStrictEqual(path, path.win32, 'should be win32 path module');
71+
assert.strictEqual(path, path.win32);
7272
else
73-
assert.deepStrictEqual(path, path.posix, 'should be posix path module');
73+
assert.strictEqual(path, path.posix);

0 commit comments

Comments
 (0)