Skip to content

Commit d360f62

Browse files
committed
test: put common lint exceptions into config file
For lint exceptions that are universal or near universal for `test/common`, put the exceptions in a config file rather than disabling the ESLint rules at the top of each file.
1 parent a518e4b commit d360f62

23 files changed

+3
-27
lines changed

β€Žtest/common/.eslintrc.yamlβ€Ž

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
rules:
2+
node-core/required-modules: off
3+
node-core/require-common-first: off

β€Žtest/common/arraystream.jsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const { Stream } = require('stream');

β€Žtest/common/benchmark.jsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
const assert = require('assert');

β€Žtest/common/countdown.jsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
const assert = require('assert');

β€Žtest/common/cpu-prof.jsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
2-
31
'use strict';
42

53
require('./');

β€Žtest/common/dns.jsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const assert = require('assert');

β€Žtest/common/duplexpair.jsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const { Duplex } = require('stream');
43
const assert = require('assert');

β€Žtest/common/fixtures.jsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32

43
const path = require('path');

β€Žtest/common/fixtures.mjsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
import fixtures from './fixtures.js';
32

43
const {

β€Žtest/common/heap.jsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/require-common-first, node-core/required-modules */
21
'use strict';
32
const assert = require('assert');
43
const util = require('util');

0 commit comments

Comments
Β (0)